• Zhi An Ng's avatar
    [x64][wasm-simd] Only require unique registers for shuffles that use temps · 12e37399
    Zhi An Ng authored
    An improvement to generic shuffle improvement
    (https://crrev.com/c/2152853) required a temporary SIMD register to hold
    the mask, rather than pushing it onto a stack. The temporary register
    requires that we UseUniqueRegister on the inputs, to prevent aliasing,
    as we will write to the temp. However, we only need this for the generic
    shuffle. We accidentally over-constraint all other pattern matched
    shuffles, since they don't use any temps.
    
    On a ~2000 line function containing ~150 shuffles (not all of which are
    generic shuffles), we get 16 less instruction in the native code, and
    actually see a very small improvement in the overall benchmarks.
    
    Bug: v8:11270
    Change-Id: I09974f7615e4b8f5e2416ed17ca47cc7613fd6b1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2591857Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71818}
    12e37399
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...