• Andreas Haas's avatar
    Reland "[wasm] Do memory.copy bounds check in C++ code" · 126f1ee1
    Andreas Haas authored
    The return value of {memory_copy_wrapper} was defined as {bool} in
    the original CL. When compiled with clang, the full return register is
    written when {true} or {false} is returned. With msvc, however, the
    return value is written as a single byte, without zero-extension. In
    generated code, the full return register is used and therefore stale
    bytes in the return register caused problems.
    
    With this CL the return value is changed to {uint32_t}. This enforces
    zero-extension of the return value and thereby fixes the issue.
    
    R=clemensb@chromium.org
    
    Bug: v8:10281
    Change-Id: I628d01cfd7193fa960a7ccdf0d9fd896f510cd3e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2096626
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66666}
    126f1ee1
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...