• Ali Ijaz Sheikh's avatar
    [heap] replace DisableInlineAllocationSteps with PauseAllocationObservers · 4623b822
    Ali Ijaz Sheikh authored
    * DisableInlineAllocationSteps was a blunt hammer added to work around
      tests that needed to avoid artificially lower limits imposed by
      observers. PauseAllocationObserversScope can properly disable step on
      a temporary basis.
    * Modify tests. Remove DisableInlineAllocationSteps.
    
    This exposed a bug in allocation observers: we were not doing a step
    when a fresh page is added.
    
    Fix this by moving the step into UpdateAllocationInfo. We should be
    doing a step (and keeping top_on_previous_step_ consistent) whenever
    we move move top(). UpdateAllocationInfo is the correct place for this
    rather than the callers of UpdateAllocationInfo.
    
    Bug: 
    Change-Id: I2edc238dc2e73bf9a2e9738c2a9b50efcac5cbf0
    Reviewed-on: https://chromium-review.googlesource.com/821052
    Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50052}
    4623b822
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...