• Clemens Backes's avatar
    [wasm] Fix stepping from a non-breakable position · 10dbddd1
    Clemens Backes authored
    ... at function start. Otherwise we run into a position mismatch:
    In a non-flooded function, we add the function-entry breakpoint (for
    "hook on function call") with the position of the first opcode.
    In the flooded function though, we skip that special breakpoint because
    we will stop at the first instruction anyway. But then the first
    instruction is non-breakable, so we don't actually emit a breakpoint for
    it.
    Hence during OSR we do not find a corresponding position in the new
    code.
    
    This CL fixes this by postponing the function-entry breakpoint until the
    first breakable opcode is found, and only emits it if that position does
    not have a breakpoint anyway.
    This way, we can also move the handling for function-entry breakpoints
    from {StartFunctionBody} to {EmitDebuggingInfo}, where it fits much
    better.
    
    R=thibaudm@chromium.org
    
    Bug: chromium:1137710
    Change-Id: Idfa658fa0897cca89ba5ee3066cd414f68864d06
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474774Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70529}
    10dbddd1
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...