• Clemens Backes's avatar
    [compiler] Fix mixed same-as-input and unique registers · 10bbbf13
    Clemens Backes authored
    The mid-tier register allocator could not handle the case that the same
    virtual register was used for
    - the input corresponding to the 'same-as-input' output, and
    - another 'unique register' input.
    
    In this case, it cannot choose the already assigned register for the
    'unique' register. Instead, it needs to allocate a new register and
    introduce a gap move to duplicate the input value in two different
    registers.
    
    FYI, the instruction where the current logic failed was:
      (v5(0), v6(R)) = IA32AddPair v7(R) v7(*) v8(R) v7(R)
    (where the last input was marked 'unique').
    
    R=leszeks@chromium.org
    CC=thibaudm@chromium.org
    
    Bug: v8:12330, chromium:1272204
    Change-Id: Ie4843aa9f5e027afe503e0481a4acdfa325dfe0e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347821Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78411}
    10bbbf13
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...