• Clemens Backes's avatar
    [compiler] Fix mixed same-as-input and unique registers · 10bbbf13
    Clemens Backes authored
    The mid-tier register allocator could not handle the case that the same
    virtual register was used for
    - the input corresponding to the 'same-as-input' output, and
    - another 'unique register' input.
    
    In this case, it cannot choose the already assigned register for the
    'unique' register. Instead, it needs to allocate a new register and
    introduce a gap move to duplicate the input value in two different
    registers.
    
    FYI, the instruction where the current logic failed was:
      (v5(0), v6(R)) = IA32AddPair v7(R) v7(*) v8(R) v7(R)
    (where the last input was marked 'unique').
    
    R=leszeks@chromium.org
    CC=thibaudm@chromium.org
    
    Bug: v8:12330, chromium:1272204
    Change-Id: Ie4843aa9f5e027afe503e0481a4acdfa325dfe0e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347821Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78411}
    10bbbf13
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...