• cbruni's avatar
    Revert of [counters] RuntimeStats: fix wrong bookkeeping when dynamically... · 10a31136
    cbruni authored
    Revert of [counters] RuntimeStats: fix wrong bookkeeping when dynamically changing counters. (patchset #10 id:180001 of https://codereview.chromium.org/2511093002/ )
    
    Reason for revert:
    Wronged it even more.
    
    Original issue's description:
    > [counters] RuntimeStats: fix wrong bookkeeping when dynamically changing counters
    >
    > RuntimeTimerScopes always subtract their own time from the parent timer's
    > counter to properly account for the own time. Once a scope is destructed it
    > adds it own timer to the current active counter. However, if the current
    > counter is changed with CorrectCurrentCounterId we will attribute all the
    > subtimers to the previous counter, and add the own time to the new counter.
    > This way it is possible to end up with negative times in certain counters but
    > the overall would still be correct.
    >
    > BUG=
    >
    > Committed: https://crrev.com/f6c74d964d9387df4bed3d8c1ded51eb9e8aa6e8
    > Cr-Commit-Position: refs/heads/master@{#41142}
    
    TBR=ishell@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=
    
    Review-Url: https://codereview.chromium.org/2519073002
    Cr-Commit-Position: refs/heads/master@{#41150}
    10a31136
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...