• Clemens Backes's avatar
    [wasm] Fix CodeSpaceWriteScope for different modules · 1023ecee
    Clemens Backes authored
    In very rare cases we open CodeSpaceWriteScopes for multiple native
    modules at the same time, e.g. for tier down (debugging) via
    
      ExecuteCompilationUnits
    --> PublishCompilationResults
    --> OnFinishedUnits
    --> TriggerCallbacks
    --> AsyncCompileJob::CompilationStateCallback::call
    --> WasmEngine::UpdateNativeModuleCache
    --> RecompileNativeModule [for tier down]
    --> InitializeRecompilation
    --> FindFunctionsToRecompile
    --> CodeSpaceWriteScope
    
    Fixing this would be difficult because we actually want to keep the
    CodeSpaceWriteScope open during subsequent publishing. So instead,
    remove the assumption that scopes are always only open for one module at
    a time.
    In order to do this, we remove the {code_space_write_nesting_level_}
    counter and instead use the {current_native_module_} field in all
    configurations to check whether a scope is currently open, and for which
    module.
    
    R=jkummerow@chromium.org
    
    Bug: v8:12644, v8:11974
    Change-Id: Idd24c87f5938c43e867c41fa1cd3879def6f3873
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3484317Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79286}
    1023ecee
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...