• Leszek Swirski's avatar
    [build] Make run_mkgrokdump explicitly dep on run_mksnapshot · 0ed32e64
    Leszek Swirski authored
    tools/debug_helper:run_mkgrokdump used to only depend on mkgrokdump.
    However, the snapshot can change without affecting the mkgrokdump
    binary itself. So, if the mkgrokdump binary doesn't change, then
    run_mkgrokdump doesn't run, even if the snapshot changed.
    
    This could cause mysterious test failures in incremental builds, in
    particular for tests testing the contents of heap-constants-gen.cc.
    
    Now, we make run_mkgrokdump depend on run_mksnapshot_default
    directly, so that snapshot updates force an mkgrokdump run.
    
    Change-Id: Ia3871e1b4fa15ec2dbc0bc5463afdb427cb39c61
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400987
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69776}
    0ed32e64
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...