• Clemens Backes's avatar
    [trap-handler] Clean up code to prepare additions · 0ea917e7
    Clemens Backes authored
    This CL cleans up the trap handler code on POSIX before making additions
    for arm64 simulator support.
    In particular,
      - it extends a comment about restoring the signal mask
        before restoring the "thread in wasm" flag, and fixes the code to
        actually implement that again;
      - it renames "SigUnmaskStack" to "UnmaskOobSignalScope", to make the
        intent clear, and it moves the signal masking code to the
        constructor of that class;
      - it replaces a call to "IsThreadInWasm" by just reading
        "g_thread_in_wasm_code" to make it more transparent what is
        happening (note that the next instruction will just write to that
        flag);
      - it replaces an if block by another early exit for consistency; and
        lastly
      - it avoids curly braces for single-line conditions, to increase
        readability and to match the rest of V8.
    
    R=ahaas@chromium.org, mseaborn@chromium.org
    
    Bug: v8:11955
    Change-Id: I023381f8b8e4640e2b21ac617fe301ec9f130783
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3015562
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75697}
    0ea917e7
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...