• Clemens Backes's avatar
    [trap-handler] Clean up code to prepare additions · 0ea917e7
    Clemens Backes authored
    This CL cleans up the trap handler code on POSIX before making additions
    for arm64 simulator support.
    In particular,
      - it extends a comment about restoring the signal mask
        before restoring the "thread in wasm" flag, and fixes the code to
        actually implement that again;
      - it renames "SigUnmaskStack" to "UnmaskOobSignalScope", to make the
        intent clear, and it moves the signal masking code to the
        constructor of that class;
      - it replaces a call to "IsThreadInWasm" by just reading
        "g_thread_in_wasm_code" to make it more transparent what is
        happening (note that the next instruction will just write to that
        flag);
      - it replaces an if block by another early exit for consistency; and
        lastly
      - it avoids curly braces for single-line conditions, to increase
        readability and to match the rest of V8.
    
    R=ahaas@chromium.org, mseaborn@chromium.org
    
    Bug: v8:11955
    Change-Id: I023381f8b8e4640e2b21ac617fe301ec9f130783
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3015562
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75697}
    0ea917e7
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...