• Andreas Haas's avatar
    [wasm] Allow dynamic tiering to release CompilationEventCallbacks · 0e6eb3e2
    Andreas Haas authored
    With eager compilation, CompilationEventCallbacks get released when all
    compilation units in the compilation state are finished. This is
    possible because no future compilation event could get triggered after
    that. With dynamic tiering, though, the {FinishedCompilationChunk} event
    can trigger repeatedly, even after all compilation units finish at some
    point in time, as dynamic tiering can create new CompilationUnits. As
    a temporary fix, CompilationEventCallbacks don't get released when
    dynamic tiering is enabled.
    
    This CL fixes this issue by turning the callback from an std::function
    into a class, and adding a second function to the class which indicates
    whether the callback can be released when all compilation units in the
    compilation state are finished. Thereby all callbacks can be deallocated
    except the ones like the code caching callback which waits for the
    {FinishedCompilationChunk} events.
    
    R=jkummerow@chromium.org
    
    Bug: v8:12289
    Change-Id: I0f73f4bd2dffe644c9a26c274cb52ac6fa49ab67
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264288
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77890}
    0e6eb3e2
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...