• Simon Zünd's avatar
    [torque] Add lint errors for unused variable and label bindings · 0e53739c
    Simon Zünd authored
    This CL adds lint errors when 'let' bindings, arguments and labels
    are not used. Note that errors for 'const' bindings will be added
    later.
    
    In cases where arguments are actually needed to match the signature,
    the warning can be silenced by prefixing identifiers with "_". This
    might be needed for generic specializations or builtins called from
    TurboFan. Trying to use a variable or label that was marked with
    "_" results in a compilation error.
    
    Implicit arguments are not linted. They are implemented using exact
    string matching. Prefixing an implicit argument with "_" in a callee
    would break all callers as the names would no longer match.
    
    Drive-by: Fix all new lint errors in the existing Torque code.
    
    Bug: v8:7793
    Change-Id: I68b3c59c76b956e9f88709e9388a40a19546ce52
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645092
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62027}
    0e53739c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...