• Clemens Backes's avatar
    [wasm] Only make needed regions writable · 0e447c4a
    Clemens Backes authored
    On Windows, the overhead of {SetPermissions} (which maps to a
    {VirtualAlloc} call) heavily depends on the amount of memory on which
    permissions are switched. Hence this CL changes permission switching
    to only switch the code regions that are actually needed. This will
    increase the number of system calls, but reduce the total size of
    switched memory.
    
    On a Unity benchmark, this reduced the lazy compilation time on Windows
    from 13.7 seconds to 3.6 seconds (3.0 seconds without write protection).
    On Linux, there is no measurable effect, but permission switching
    generally seems to have way less overhead on Linux.
    
    R=jkummerow@chromium.org
    
    Bug: v8:11974
    Change-Id: I46dd4ae9997587226b3d81166cf2e1128383ab34
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3077144
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76163}
    0e447c4a
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...