• Benedikt Meurer's avatar
    [debug] Always return a valid PropertyDescriptor. · 0de01928
    Benedikt Meurer authored
    In DebugPropertyIterator::iterator() we were assuming that the call to
    JSReceiver::GetOwnPropertyDescriptor() would always yield either an
    exception or a valid property descriptor. But that's not guaranteed to
    be the case (anymore), because JSReceiver::GetOwnPropertyDescriptor()
    nowadays can chicken out with `false` for many different reasons.
    
    Coincidentally the callsites to DebugPropertyIterator::iterator() are
    already equipped to handle the case where of an empty property
    descriptor, which is basically what we get out here. So this CL adjusts
    the DebugPropertyIterator to return an empty descriptor in this case.
    
    Fixed: chromium:1291240
    Change-Id: I22a9d0cde2b2c6d3966a85478ed0b87fb4c5d232
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3736445Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81458}
    0de01928
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...