• Sigurd Schneider's avatar
    [coverage] Correctly report coverage for inline scripts · 0d7889d0
    Sigurd Schneider authored
    This fixes a bug where coverage for the inline script
      <script>function foo() {}<script>
    started to get deterministically reported as covered
    after crrev.com/c/1771776, while before it, we most of
    the time reported it as uncovered (depending on heap
    order of SFIs). The correct result is to report `foo`
    as uncovered as it is never called.
    
    The problem arose from the fact that v8:9212 needed to
    handle extra-wrappers around scripts correctly. Those
    wrappers have the same source range as the wrapped
    script and a call count of zero even if the wrapped
    script is executed. To filter them out, we previously
    determined nesting for identical source ranges by
    ascending call count. However, in the script case above,
    the script has call count one, while `foo` (which has
    the same source range) has call count zero. In this
    case, nesting is decreasing order of call counts.
    
    This CL is a minimal change that sorts SFIs which are
    top-level to the front, only then considers call counts
    in descending order. This preserves the behavior that
    node's extra wrappers are sorted to the front (and
    then filtered out by existing logic), but also ensures
    that for the example above, we report the script's
    coverage before the coverage for `foo`.
    
    
    Bug: v8:9857, v9:9212
    Change-Id: Id224b0d8f12028b1f586ee5039e126bb5b8d8d36
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863197Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64307}
    0d7889d0
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...