• Sigurd Schneider's avatar
    [coverage] Correctly report coverage for inline scripts · 0d7889d0
    Sigurd Schneider authored
    This fixes a bug where coverage for the inline script
      <script>function foo() {}<script>
    started to get deterministically reported as covered
    after crrev.com/c/1771776, while before it, we most of
    the time reported it as uncovered (depending on heap
    order of SFIs). The correct result is to report `foo`
    as uncovered as it is never called.
    
    The problem arose from the fact that v8:9212 needed to
    handle extra-wrappers around scripts correctly. Those
    wrappers have the same source range as the wrapped
    script and a call count of zero even if the wrapped
    script is executed. To filter them out, we previously
    determined nesting for identical source ranges by
    ascending call count. However, in the script case above,
    the script has call count one, while `foo` (which has
    the same source range) has call count zero. In this
    case, nesting is decreasing order of call counts.
    
    This CL is a minimal change that sorts SFIs which are
    top-level to the front, only then considers call counts
    in descending order. This preserves the behavior that
    node's extra wrappers are sorted to the front (and
    then filtered out by existing logic), but also ensures
    that for the example above, we report the script's
    coverage before the coverage for `foo`.
    
    
    Bug: v8:9857, v9:9212
    Change-Id: Id224b0d8f12028b1f586ee5039e126bb5b8d8d36
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863197Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64307}
    0d7889d0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...