• clemensh's avatar
    [wasm] Make reported "lines" on stack frames 1-based · 0c6fa172
    clemensh authored
    In captured stack traces, all lines and columns must be 1-based.
    Even though this makes things a bit ugly, we have to comply also for
    wasm locations, where line and column encode function index and byte
    offset (both are originally 0-based).
    
    If we don't comply, the frontend might complain, as e.g. DevTools does.
    
    BUG=chromium:659715
    R=yangguo@chromium.org, kozyatinskiy@chromium.org
    CC=titzer@chromium.org
    
    Review-Url: https://codereview.chromium.org/2493943002
    Cr-Commit-Position: refs/heads/master@{#40971}
    0c6fa172
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...