• Kim-Anh Tran's avatar
    [debug] Capture more cases for instrumentation breakpoints · 0c3fdff2
    Kim-Anh Tran authored
    The previous implementation would not explicitly send
    `Debugger.paused` events for instrumentation breakpoints
    if they were to overlap with breaks due to:
    * regular breakpoints
    * OOM
    * exceptions
    * asserts
    
    This CL is a step towards making sure that a separate
    `Debugger.paused` event is always sent for an instrumentation
    breakpoint. In some cases where we have overlapping reasons
    but only know of one, the 'instrumentation' reason,
    we still just send out one paused event with the reason
    being `instrumentation`.
    
    Drive-by: send instrumentation notification to all sessions,
    remember which breakpoints are instrumentation breakpoints
    
    Bug: chromium:1229541, chromium:1133307
    Change-Id: Ie15438f78b8b81a89c64fa291ce7ecc36ebb2182
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211892Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77333}
    0c3fdff2
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...