• Clemens Hammacher's avatar
    [tracing] Fix data race · 0ba3de60
    Clemens Hammacher authored
    There is a data race if several background threads check for a tracing
    flag concurrently. Both will call {GetCategoryGroupEnabledInternal}.
    The first one not find the category in the {g_category_group_enabled}
    array, and hence will add it and call {UpdateCategoryGroupEnabledFlag}
    to initialize the flag. The second thread then finds the entry in the
    array and reads it without any synchronization, which is a data race.
    
    Since we do not really care about this race, we just use a
    {Relaxed_Load} to read the field. TSan is fine with that.
    
    R=yangguo@chromium.org
    CC=ofrobots@google.com
    
    Bug: v8:8221
    Change-Id: Ie09141e3d845956d3c487a463f00b7d6cd413513
    Reviewed-on: https://chromium-review.googlesource.com/1245424Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56256}
    0ba3de60
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...