• Darius M's avatar
    Reland [compiler] Simplify "==0" branches in MachineOperatorReducer · 6b690a6b
    Darius M authored
    This is a reland of 48b443f6.
    
    While fixing the initial CL, we stumbled upon a few bugs that
    we had to fix:
    
     - CommonOperatorReducer and SimplifiedOperatorReducer were applied
       before and after SimplifiedLowering, but always assumed that it
       was before SimplifiedLowering, and thus had the wrong semantics
       for branches in some cases. They now have an added parameter to
       know which semantics of branch they should use.
    
     - The lowering of StaticAssert was wrong and could leave kHeapConstant
       in the assert (instead of machine Booleans).
    
    Original change's description:
    > [compiler] Simplify "==0" branches in MachineOperatorReducer
    >
    > Bug: v8:12484
    > Change-Id: I0667c7464c0dd71338bc199a24a69248a7a0a525
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497303
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Owners-Override: Tobias Tebbi <tebbi@chromium.org>
    > Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#79379}
    
    Bug: v8:12484
    Change-Id: Ibbf5df96fce5ccb04868dc517539479bf69f5703
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3516869Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79528}
    6b690a6b
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
debug Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regexp Loading commit data...
regress Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
avoid-windows-h-includes.cc Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...