• Michael Lippautz's avatar
    api,heap: Avoid reaching out to embedder memory on TracedGlobal reset · 0af80a37
    Michael Lippautz authored
    Avoid clearing the memory on the embedder-side of a TracedGlobal handle.
    
    When using destructors in TracedGlobal this is safe as long as the embedder
    reports the handle on tracing GCs. If the embedder does not report a handle it
    is assumed that the containing object is dead as well.
    
    Without using destructors the same argument holds for tracing GCs. In addition,
    embedders using the optimization of clearing references on non-tracing GCs
    are expected to clear the reference in ResetHandleInNonTracingGC.
    
    It is suggested that only expert embedders make use of (a) no destructors and
    (b) IsRootForNonTracingGC.
    
    Change-Id: Ia417c0eb0860094fcaa554e7046d38abac905714
    Bug: chromium:995684
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1763539
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63362}
    0af80a37
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...