• Jakob Gruber's avatar
    [factory] Refactor JSFunction construction · 09ef5458
    Jakob Gruber authored
    Construction of JSFunction objects is complex, mostly due to the
    existence of multiple functions kinds (JS, wasm, builtin, test, ...)
    that are all created slightly differently. For example, JS functions
    may come with an existing FeedbackCell (and FeedbackVector), while
    builtins and wasm functions always use the many_closures_cell (without
    a vector).
    
    Prior to this CL, construction logic was scattered over a family of
    7 functions, without a clearly defined chokepoint for header
    initialization. This was hard to understand, hard to modify, and
    needlessly inefficient (by setting some fields twice).
    
    This CL fixes all that by introducing JSFunctionBuilder. The BuildRaw
    method is the chokepoint for allocation and initialization, and Build
    performs common pre- and post-work.
    
    Future work:
    - Remove now-deprecated functions.
    - Untangle SFI/Map/JSFunction construction and remove
      Factory::NewFunction and NewFunctionArgs.
    
    Bug: v8:8888
    Change-Id: I709a2a44ee02e10593a4c9afe43d4d2c6d6351c4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527098Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71084}
    09ef5458
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...