• Jakob Gruber's avatar
    [factory] Refactor JSFunction construction · 09ef5458
    Jakob Gruber authored
    Construction of JSFunction objects is complex, mostly due to the
    existence of multiple functions kinds (JS, wasm, builtin, test, ...)
    that are all created slightly differently. For example, JS functions
    may come with an existing FeedbackCell (and FeedbackVector), while
    builtins and wasm functions always use the many_closures_cell (without
    a vector).
    
    Prior to this CL, construction logic was scattered over a family of
    7 functions, without a clearly defined chokepoint for header
    initialization. This was hard to understand, hard to modify, and
    needlessly inefficient (by setting some fields twice).
    
    This CL fixes all that by introducing JSFunctionBuilder. The BuildRaw
    method is the chokepoint for allocation and initialization, and Build
    performs common pre- and post-work.
    
    Future work:
    - Remove now-deprecated functions.
    - Untangle SFI/Map/JSFunction construction and remove
      Factory::NewFunction and NewFunctionArgs.
    
    Bug: v8:8888
    Change-Id: I709a2a44ee02e10593a4c9afe43d4d2c6d6351c4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527098Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71084}
    09ef5458
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...