• Clemens Hammacher's avatar
    [wasm][gc] Fix NativeModule::GetCode for nonexisting code · 0975c554
    Clemens Hammacher authored
    {NativeModule::GetCode} can actually return {nullptr} if no code was
    compiled yet for a function, e.g. in asm.js where we use lazy
    compilation. In that case, we must not try to increment the ref count
    on the nonexisting code object.
    
    We had a few errors recently that were hard to reproduce because we do
    not have a flag to enable code logging. Clusterfuzz managed to
    accomplish this by passing --trace-ic.
    In order to test bugs in code logging properly, this CL introduces a
    new runtime function called "EnableCodeLoggingForTesting". It registers
    a noop {CodeEventListener} and enables code logging in the wasm engine.
    We should whitelist this flag in ClusterFuzz to potentially flush out
    more bugs.
    
    R=mstarzinger@chromium.org
    CC=frgossen@chromium.org
    
    Bug: v8:8217, chromium:961129, chromium:961245, chromium:961128
    Change-Id: I2f97c109db70b41531d58580b71f6781beeb8dcb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1602700
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61404}
    0975c554
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...