• caitpotter88's avatar
    [es6] allow any LeftHandSideExpression in for-of loops · 096125de
    caitpotter88 authored
    Fix an earlier regression which forbid non-VariableProxy LHS from being
    used in for-of loops. Like for-in loops, the spec allows any LHS to be used,
    with the sole exception that ObjectLiterals and ArrayLiterals must be valid
    AssignmentPatterns.
    
    Also fixes a bug in TurboFan which resulted in incorrectly replacing a variable load with a constant value in some instances, due to the AstLoopAssignmentAnalyzer failing to record the assignment to ForOfStatement's value.
    
    BUG=v8:4418, v8:2720
    LOG=N
    R=wingo@igalia.com, littledan@chromium.org, adamk@chromium.org, bmeurer@chromium.org
    
    Review URL: https://codereview.chromium.org/1411873004
    
    Cr-Commit-Position: refs/heads/master@{#31816}
    096125de
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...