• Benedikt Meurer's avatar
    [turbofan] Don't introduce PlainPrimitiveToNumber for String inputs. · 09410621
    Benedikt Meurer authored
    During JSTypedLowering we can decide to insert PlainPrimitiveToNumber
    operators on the inputs to still utilize pure Number operators, when
    the type feedback on the numeric binary operation is NumberOrOddball.
    However that is not beneficial if the inputs can be Strings, that is
    we cannot statically rule out String based on input type, as that
    inserts a ToNumber stub call into the hot code path.
    
    This repairs the NavierStokes regression with Ignition on Octane.
    
    R=jarin@chromium.org
    
    Review URL: https://codereview.chromium.org/2432143003 .
    
    Cr-Commit-Position: refs/heads/master@{#40427}
    09410621
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...