• Benedikt Meurer's avatar
    [ic] Properly handle polymorphic symbol accesses. · 08db4d76
    Benedikt Meurer authored
    Until now keyed accesses to properties with string or symbol keys were
    only optimized properly while the IC was monomorphic and would go
    megamorphic as soon as there's another receiver map, even if the name
    was still the same (i.e. the same symbol or internalized string). This
    was a weird performance-cliff, that'll hurt modern code especially
    because for symbols you can only access them via keyed loads and stores.
    
    This CL fixes the state machine inside the ICs to properly transition to
    POLYMORPHIC state (and stay there) as long as the new name matches the
    previously recorded name. The FeedbackVector and TurboFan were already
    able to deal with this and didn't need any updates.
    
    On the micro-benchmark from the tracking bug we go from
    
      testStringMonomorphic: 429 ms.
      testSymbolMonomorphic: 431 ms.
      testStringPolymorphic: 429 ms.
      testSymbolPolymorphic: 5621 ms.
    
    to
    
      testStringMonomorphic: 429 ms.
      testSymbolMonomorphic: 429 ms.
      testStringPolymorphic: 429 ms.
      testSymbolPolymorphic: 430 ms.
    
    effectively eliminating the overhead for symbols completely, and
    yielding a 13.5x performance boost.
    
    This also seems to yield a 1% improvement on the ARES6 ML benchmark,
    because it eliminates the KEYED_LOAD_ICs for the Symbol.species lookups.
    
    Bug: v8:6367, v8:6278, v8:6344
    Change-Id: I879fe56387b4c56203c1ad8ef8cafb6cc4c32897
    Reviewed-on: https://chromium-review.googlesource.com/695108Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48261}
    08db4d76
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...