• Benedikt Meurer's avatar
    [inspector] Reduce upper bound for async stack traces. · 08aa49eb
    Benedikt Meurer authored
    The V8Debugger maintains a list of async stack traces that were captured
    so far, two mappings pointing weakly to async stack traces in this (one
    mapping for tasks and one mapping for stored async stack traces). The
    V8Debugger regularly prunes the list (and cleans up the stale weak
    pointers afterwards) by going through the list in insertion order and
    removing items until the number is below half the limit of 128k entries.
    
    This approach wastes a lot of memory, since the list grows very big
    before this manual collection starts, and it doesn't pay any attention
    to whether the stack traces are still in active use or not. Also the
    limit of 128k seems incredibly high (and arbitrary).
    
    This leads to crashes observed in applications with lots of async task
    activity (i.e. huge Angular applications) as soon as the debugger is
    attached.
    
    This CL performs a quickfix by reducing the limit for async stack traces
    to a more reasonable number of 8k. We will need to follow up with a
    proper fix that ensures that we only hold on strongly to async stack
    traces that are still in need.
    
    Also-By: jarin@chromium.org
    Fixed: chromium:1258000
    Bug: chromium:1257637, chromium:1254279, chromium:1203218
    Change-Id: I2c482a688df4c6df575a0045d443db89d89b3d73
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211709
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77301}
    08aa49eb
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...