• Eric Holk's avatar
    [wasm] Remove racy DCHECKs · 07ef612f
    Eric Holk authored
    These DCHECKs involve reading and comparing two variables that may be modified
    on a separate thread. Thus, there is no way to ensure these comparisons happen
    atomically. This leads to runtime failures that are otherwise benign.
    
    The other option would be to take the memory tracker mutex, but this seems
    unnecessary given that two atomic counters is sufficient and these checks are
    only used during debug builds.
    
    Bug: chromium:838043
    Change-Id: I1b87698c46c550bd2d58bfef956b5a07cb2ec52c
    Reviewed-on: https://chromium-review.googlesource.com/1038886Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Eric Holk <eholk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52920}
    07ef612f
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...