• yangguo's avatar
    [serializer] Ensure immortal immovable roots are deserialized correctly. · 07d40b74
    yangguo authored
    The serializer collects objects in iteration order, not in allocation
    order. This means that the deserializer will put these objects in
    iteration order onto the reserved pages as well. There is no guarantee
    that objects that were on the first page will end up on the first page
    after deserialization.
    
    Until now we got lucky, since we only ever need one space per page for
    the default snapshot. For roots, the iteration order and allocation
    order also do not differ enough to cause any issue for immortal
    immovable root objects. These objects need to stay on the first page of
    its allocated space to not move.
    
    However, let's make sure it stays this way, and we realize soon enough
    if this assumption does not hold.
    
    R=mstarzinger@chromium.org
    
    Review URL: https://codereview.chromium.org/1675553002
    
    Cr-Commit-Position: refs/heads/master@{#33810}
    07d40b74
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...