• Clemens Hammacher's avatar
    [wasm] Fix missing cancellation of background compilation · 07aafb76
    Clemens Hammacher authored
    In {WasmEngine::DeleteCompileJobsOnIsolate} (triggered on isolate
    teardown), we are deleting the {AsyncCompileJob} with the expectation
    that this cancels all background compilation. Since the introduction of
    the CompilationState, this is not true any more. The call to
    {CompilationState::Abort} is missing.
    This CL fixes this by moving the logic from {AsyncCompileJob::Abort} to
    {~AsyncCompileJob}, since the former calls the latter anyway.
    
    R=ahaas@chromium.org
    
    Bug: chromium:869420
    Change-Id: I4644d161270def0fe3a94d09cde0135ee420a383
    Reviewed-on: https://chromium-review.googlesource.com/1172285Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55083}
    07aafb76
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...