• Clemens Hammacher's avatar
    [wasm][arm] Cleanup LTO bug avoidance · 077c897c
    Clemens Hammacher authored
    We landed two mitigations for the bug, and crash data shows that it is
    indeed fixed. It is still not clear whether this is a compiler bug,
    wrong use of inline assembly, or LTO. The original fix to move the call
    to {FlushInstructionCache} should not be needed any more though.
    This CL thus reverts https://crrev.com/c/1571619 and uses V8_NOINLINE
    instead of the noinline attribute.
    If this reintroduces any crashes, please revert. We are far enough away
    from the branch to detect this on canary without too much trouble.
    
    R=jkummerow@chromium.org
    
    Bug: chromium:952759
    Change-Id: I76f9850d8d6a8af0926b88e961f89df41b662ae7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1611677Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61477}
    077c897c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...