• Manos Koukoutos's avatar
    [wasm] Refactor initializer expression handling · 071a1acf
    Manos Koukoutos authored
    Design doc: https://bit.ly/3xPxWUe
    
    This CL introduces two main changes:
    - Initializer expressions are now decoded by WasmFullDecoder. With
      wasm-gc, initializer expressions are no longer just constants, and
      require complex decoding (including stack tracking). This resulted in
      extensive code duplication.
    - Initializer expressions are not stored explicitly by module-decoder as
      an AST (WasmInitExpr), but rather as a WireBytesRef, and are decoded
      again during module instantiation. This should reduce memory
      consumption for globals and other module elements with initializer
      expressions (which has been observed in the 40MB range in some
      real-world benchmarks.
    
    Summary of changes:
    - Add a static parameter {kFunctionBody, kInitExpression} to the
      WasmDecoder. Use it to specialize validation to function bodies/init.
      expressions.
    - Introduce a new Interface for the WasmFullDecoder for init.
      expressions.
    - Differentiate between constant and non-constant opcodes in
      WasmFullDecoder.
    - Change representation of init. expressions in WasmModule to
      WireBytesRef.
    - Reimplement EvaluateInitExpression in module-instantiate to re-decode
      initializer expressions.
    - Remove some now-invalid module decoder tests.
    
    Pending changes:
    - Also refactor initializer expressions for element segment entries.
    - Reintroduce deleted tests.
    
    Bug: v8:11895
    Change-Id: I76512bfe1386c8338667d30fa6db93880a1e4b42
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972910Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75476}
    071a1acf
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...