• Darius M's avatar
    Reland^2 [compiler] Simplify "==0" branches in MachineOperatorReducer · 0719ace6
    Darius M authored
    This is a reland of 6b690a6b.
    
    The previous version of this CL was a bit too aggressive in the
    duplication of branch conditions. This caused an increase in
    register pressure in some cases, thus reducing performance.
    
    In fact, duplicating branch conditions that require an "== 0" to be
    added provides no benefits. We are thus now a bit less aggressive, and
    only duplicate comparisons.
    
    Original change's description:
    > Reland [compiler] Simplify "==0" branches in MachineOperatorReducer
    >
    > This is a reland of 48b443f6.
    >
    > While fixing the initial CL, we stumbled upon a few bugs that
    > we had to fix:
    >
    >  - CommonOperatorReducer and SimplifiedOperatorReducer were applied
    >    before and after SimplifiedLowering, but always assumed that it
    >    was before SimplifiedLowering, and thus had the wrong semantics
    >    for branches in some cases. They now have an added parameter to
    >    know which semantics of branch they should use.
    >
    >  - The lowering of StaticAssert was wrong and could leave kHeapConstant
    >    in the assert (instead of machine Booleans).
    >
    > Original change's description:
    > > [compiler] Simplify "==0" branches in MachineOperatorReducer
    > >
    > > Bug: v8:12484
    > > Change-Id: I0667c7464c0dd71338bc199a24a69248a7a0a525
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497303
    > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > > Owners-Override: Tobias Tebbi <tebbi@chromium.org>
    > > Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    > > Cr-Commit-Position: refs/heads/main@{#79379}
    >
    > Bug: v8:12484
    > Change-Id: Ibbf5df96fce5ccb04868dc517539479bf69f5703
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3516869
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#79528}
    
    Bug: v8:12484
    Change-Id: I31f575a59811a83c7c1acb4c14bf5ded63a8f536
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3540102Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79560}
    0719ace6
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...