• Jakob Kummerow's avatar
    [stringrefs] Fix inlining, and some corner case bugs · 0661a0dd
    Jakob Kummerow authored
    1) Inlining functions that contain stringref operations require builtin
       calls to be marked as kNoThrow appropriately (or have exception
       handling support in the graph).
    2) Some overly-large inputs for string creation hit DCHECKs before
       getting to the places where they would have thrown an orderly
       exception.
    3) We still had a known issue that some exceptions thrown by JS-focused
       code were erroneously catchable by Wasm.
    4) When string.concat attempted to create a too-long string, it ran into
       a DCHECK because we didn't clear the "thread in wasm" flag.
    5) The builtin call for string.concat was erroneously marked as
       kEliminatable, which could cause the trap get eliminated.
    
    Bug: v8:12868
    Change-Id: Iad3ada0e2465bfd8f3d00bb064c32049d6b19d87
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3902522
    Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Andy Wingo <wingo@igalia.com>
    Reviewed-by: 's avatarAndy Wingo <wingo@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#83292}
    0661a0dd
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...