• Camillo Bruni's avatar
    [d8] Disable d8.promise.setHooks with correctness fuzzing · 060c2cb1
    Camillo Bruni authored
    Setting promise hooks after running some promise-related code has hard
    to control side-effects that make correctness fuzzing difficult.
    
    Certain Promise functions are optimized and avoid creating intermediate
    Promises. Dynamically enabled Promise hooks combined with --force-slow-path,
    which would cause us to always create those intermediate Promises, will
    get us very differet callbacks if the hooks are enabled half-way.
    
    The exepected usage pattern is to only use setHooks if there are no
    pending promises, something that cannot be guaranteed for fuzzing.
    
    Bug: chromium:1202465
    Change-Id: Ifa96f2db9c441b6f5da696b88a1c087160ec8eeb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3013355Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75637}
    060c2cb1
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...