• Ng Zhi An's avatar
    Reland "[wasm-simd][liftoff][arm][arm64] Implement integer narrowing" · 050a7e05
    Ng Zhi An authored
    This relands commit 387d85ad.
    
    This was passing in the simulator because of the typo in
    simulator-arm.cc. The instr->Bit(7,6) call is incorrect, it should be
    Bit (no s). I don't really know what it resolves to, but the effect is
    that we get src_unsigned is false when we expect it to be true.
    
    With the simulator fix, we get the same error as non-simulator runs. The
    fix is in liftoff-assembler-arm.h, we need to be passing both source and
    dst data types to vmovqn. This was already done correctly in
    code-generator-arm, but I was careless in copying the logic...
    
    Bug: v8:9909
    
    Original change's description:
    > [wasm-simd][liftoff][arm][arm64] Implement integer narrowing
    >
    > Bug: v8:9909
    > Change-Id: I0664df45fe399bfa018ff8bcacdbdae66944ed29
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154834
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Commit-Queue: Zhi An Ng <zhin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67254}
    
    Change-Id: If17f13aae40569174635283abec5ea1358286f55
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2157799Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Auto-Submit: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67287}
    050a7e05
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...