• Anton Bikineev's avatar
    cppgc: Force EBO to always work with GCed · 92eae6d1
    Anton Bikineev authored
    Currently, in the following struct
    
    struct LayoutObject : GarbageCollected<>, MixinA, MixinB {};
    
    the subobject that corresponds to the first base GarbageCollected<>
    always takes up some space (one word). The empty-base-optimization
    doesn't happen because the second base (MixinA) has the same subobject
    as the first base (GarbageCollected), which is the most parent class
    GarbageCollectedBase. The compiler can't "merge" them because it must
    guarantee that distinct objects of the same type have distinct
    addresses.
    
    The attribute [[no_unique_address]] doesn't work for base classes,
    unfortunately (but is a good idea for a Standard proposal). As a
    solution, the CL simply removes GarbageCollectedBase.
    
    Bug: chromium:1260797
    Change-Id: I415b10a5fbcebce3d6ee97b8870ea9ae90f383a8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259654
    Commit-Queue: Anton Bikineev <bikineev@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77693}
    92eae6d1
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
debug Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regexp Loading commit data...
regress Loading commit data...
runtime Loading commit data...
security Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
avoid-windows-h-includes.cc Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...