• Dominik Inführ's avatar
    [heap] Only main thread handles may reference left-trimmed objects · c2297cae
    Dominik Inführ authored
    Left-trimming only works when there is a single reference to the
    backing store from the JS object. Main thread handles are an exception
    to this rule because it is not feasible to ensure that no such
    leftover handles may store such stale pointers.
    
    FixStaleLeftTrimmedHandlesVisitor clears such references
    in main thread handles, such that the GC never tries to visit them. This
    CL renames this class to ClearStaleLeftTrimmedHandlesVisitor to
    emphasize that such slots are cleared rather than "fixed up" to point
    to the new object start.
    
    Previously ClearStaleLeftTrimmedHandlesVisitor was used for local
    and persistent handles as well. Starting with this CL, stale references
    to left-trimmed objects are only allowed in main thread handles.
    https://crrev.com/c/2928502 enabled us to be more restrictive here.
    
    Change-Id: If4db0630f1df2d6c3fe5f242bf866c57a8ae2969
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944807Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74989}
    c2297cae
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...