• Manos Koukoutos's avatar
    [turbofan] Disallow floating control in wasm · 02ac71e2
    Manos Koukoutos authored
    Loop unrolling did not work properly with floating control. Seeing as
    very few spots in the wasm compiler introduced floating control, we
    decided to disallow it altogether.
    Changes:
    - When lowering 64-bit rol/ror/clz/ctz in 32-bit platforms, we use a
      diamond operator, which used to introduce floating control. This CL
      adds a control edge to these operators so that the diamond can be
      chained to that control instead.
    - During loop analysis, as an additional safety check, we check that the
      explored loop does not have floating control. Exceptionally, floating
      control pointing directly do start() is allowed.
    - Change wasm-compiler so that generated floating projections point to
      start() even after stack check patch-in.
    
    Bug: chromium:1184929, v8:11298
    Change-Id: I1ee063f5250037ae6c84d2f16b0bd8fff3923117
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2876851Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74527}
    02ac71e2
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...