• Manos Koukoutos's avatar
    [turbofan] Disallow floating control in wasm · 02ac71e2
    Manos Koukoutos authored
    Loop unrolling did not work properly with floating control. Seeing as
    very few spots in the wasm compiler introduced floating control, we
    decided to disallow it altogether.
    Changes:
    - When lowering 64-bit rol/ror/clz/ctz in 32-bit platforms, we use a
      diamond operator, which used to introduce floating control. This CL
      adds a control edge to these operators so that the diamond can be
      chained to that control instead.
    - During loop analysis, as an additional safety check, we check that the
      explored loop does not have floating control. Exceptionally, floating
      control pointing directly do start() is allowed.
    - Change wasm-compiler so that generated floating projections point to
      start() even after stack check patch-in.
    
    Bug: chromium:1184929, v8:11298
    Change-Id: I1ee063f5250037ae6c84d2f16b0bd8fff3923117
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2876851Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74527}
    02ac71e2
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...