• Clemens Backes's avatar
    [compiler] Do not rely on register indexes · 010fcac1
    Clemens Backes authored
    For getting from one SIMD "sibling" register to the other, the mid tier
    register allocator was relying on the indexes of the two registers to be
    {2N} and {2N+1}. This is only true for lower SIMD registers; later
    registers can be at {2N-1} and {2N} instead, because of holes in the
    allocatable double registers (e.g. d13-d15 are not allocatable currently
    on ARM).
    
    We can rely on other facts though:
    1) The two aliasing registers are always successive.
    2) A SIMD register code always maps to the lower register index.
    3) We can get from an F32 register code to F64 and from F64 to S128 by
       shifting one bit to the right (this is what
       {RegisterConfiguration::GetAliases} uses).
    
    This bug was uncovered by running the existing
    cctest/test-code-generator/FuzzAssemble* tests with either
    --turbo-use-mid-tier-regalloc-for-huge-functions or with
    --turbo-force-mid-tier-regalloc. Hence it will be covered by these tests
    once https://crrev.com/c/3347822 lands.
    
    R=thibaudm@chromium.org
    TEST=cctest/test-code-generator/FuzzAssemble*
    
    Bug: v8:12330
    Change-Id: I168840fe50b6ba6cdaa6a5462596a5cbf55c87ec
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3378782Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78632}
    010fcac1
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...