- 17 May, 2018 3 commits
-
-
Anna Henningsen authored
Turn `debug::EntriesPreview` into a public API. This is a straightforward approach to addressing https://github.com/nodejs/node/issues/20409 (not relying on functionality behind `--allow-natives-syntax`) in Node.js. Refs: https://github.com/nodejs/node/issues/20409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7021e5846012a55a82c488408ded6591f6b139e7 Reviewed-on: https://chromium-review.googlesource.com/1057467Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53226}
-
Anna Henningsen authored
Without specifying what the default allocator does, using the buffer returned from `Release()` means that one basically had to make an educated guess on how to free it (and that ownership actually was transferred to the caller). Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie2ac0c91d9bdafbe91f6bce9b2263e304b2336ea Reviewed-on: https://chromium-review.googlesource.com/1056369Reviewed-by:
-
Nebojsa Ciric authored
Bug: v8:7765 Change-Id: I9366e28db004dcc565d654be2bb2fd62a12ebff1 Reviewed-on: https://chromium-review.googlesource.com/1062952Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#53224}
-
- 16 May, 2018 30 commits
-
-
Gabriel Charette authored
Also fixup some implementations that were lagging behind per the lack of pure virtual not having enforced everything yet. Also fixed recently introduced PredictablePlatform::CallDelayedOnWorkerThread() to ignore delayed tasks after realizing the intent is to intercept worker tasks instead of sending them to |platform_|. Node.js migrated off these APIs @ https://github.com/v8/node/pull/69 R=ahaas@chromium.org, yangguo@chromium.org Bug: chromium:817421 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I92171f213b5fc64ab1f21e8eec72738f5ce228bd Reviewed-on: https://chromium-review.googlesource.com/1045310 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53223}
-
Alexei Filippov authored
Currently ProfilerListener holds all the CodeEntries it ever created during the profiling session. It is not capable of removing entries corresponding to the code objects discarded by GC as there's no such code event. However it is sometimes possible to tell if a code object was GCed. Hook up to the CodeMap code entry removal and if the entry has never been hit by a sample we can safely delete it. As a bonus the CodeEntryInfo size has been reduced on x64, which also saves 8 x <number of code entries> bytes. BUG=v8:7719 Change-Id: I988bc5b59f3fba07157a9f472cbcf68596fcd969 Reviewed-on: https://chromium-review.googlesource.com/1054346Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#53222}
-
Tobias Tebbi authored
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I20e30f0c19c887b1e093b02e39c7bd3d53d15182 Reviewed-on: https://chromium-review.googlesource.com/1054073 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#53221}
-
Clemens Hammacher authored
In the context of launching Liftoff, this will help us estimate the code size increase and find a good value for the maximum allowed code space. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ie76172edbf136629636911fe97c7ecdc940be86d Reviewed-on: https://chromium-review.googlesource.com/1061497 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53220}
-
Bill Budge authored
- Changes WASM serialization to copy misaligned code into an aligned buffer before relocating. This extra copy will eventually go away when code is mapped into the process. - Serialized code buffers no longer need padding to align their contents. Change-Id: Ib016c69b5099a4cf039dcd3d36a48f076033227c Reviewed-on: https://chromium-review.googlesource.com/1060471Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#53219}
-
Michael Starzinger authored
R=cbruni@chromium.org BUG=chromium:842862 Change-Id: I1b7ba33ffdfc3bb7542308ccc68a14696db5f583 Reviewed-on: https://chromium-review.googlesource.com/1061519Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53218}
-
Tobias Tebbi authored
This CL adds the new type expression builtin(Context, ArgType1, ...) => ReturnType and allows to use Torque-defined builtins as values of this type, as well as calling values of this type. The new function pointer types are subtypes of Code. Change-Id: Ib7ba3ce6ef7a8591a4c79230dd189fd25698d5b9 Reviewed-on: https://chromium-review.googlesource.com/1060056 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: chromium:843543 Change-Id: I709c4be330e7d45e597b3ca4ae9db8a960b07bbc Reviewed-on: https://chromium-review.googlesource.com/1061463Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53216}
-
Sergiy Byelozyorov authored
This is a reland of 989285b7 Original change's description: > [tools] Add benchmark owners to the config > > R=machenbach@chromium.org > > No-Try: true > Bug: chromium:826280 > Change-Id: Ic34d13170dfecdd9e791974a34c33ba0248c7a38 > Reviewed-on: https://chromium-review.googlesource.com/1053809 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53138} TBR=machenbach@chromium.org No-Try: true Bug: chromium:826280 Change-Id: I169788ff40dd88a7017b46a15b292568b907f38e Reviewed-on: https://chromium-review.googlesource.com/1061697 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#53215}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:651354 Change-Id: I9ce5c6dc6a155ff9a70713cbdbf2d4037ad47f24 Reviewed-on: https://chromium-review.googlesource.com/1053773 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53214}
-
Sigurd Schneider authored
This CL adds support for inlined functions in Turbolizer. It is also a refactoring of the Turbolizer code-base. Most importantly, handling of source positions changed to exact source positions, and not code ranges. This improves selection interoperability between different phase views. A separate CL changes the Turbolizer JSON format to include inlining information. This Turbolizer update, however, is intended to be backwards compatible with the JSON format Turbolizer generated before the JSON format change. Bug: v8:7327 Change-Id: Ic67506a6f3a36fe98c012b1e76994972779c1fd2 Reviewed-on: https://chromium-review.googlesource.com/1032784 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
This is a reland of 989285b7 Original change's description: > [tools] Add benchmark owners to the config > > R=machenbach@chromium.org > > No-Try: true > Bug: chromium:826280 > Change-Id: Ic34d13170dfecdd9e791974a34c33ba0248c7a38 > Reviewed-on: https://chromium-review.googlesource.com/1053809 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53138} R=machenbach@chromium.org No-Try: true Bug: chromium:826280 Change-Id: Ie61892c80d5ce004703d3e769abd58c4f2af1eec Reviewed-on: https://chromium-review.googlesource.com/1057092Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Ic00291784e982632b15cd83059397b6e9e4c4f79 Reviewed-on: https://chromium-review.googlesource.com/1057487 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53211}
-
jgruber authored
It is possible for user code to modify fast regexp result objects before they are used e.g. by RegExp.p.match, so we may not make any assumptions about their contents. The only exception is when the RegExp itself is fast. Bug: chromium:843022 Change-Id: I14eafbdfb2b2ced609da1391b57c73cbe167f7fb Reviewed-on: https://chromium-review.googlesource.com/1061455Reviewed-by:
Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Camillo Bruni authored
Tentative fix for Android invoke crashers with write protection code enabled. Bug: chromium:842862 Change-Id: If238b25b239b50c597f3745aa683f564a717434f Reviewed-on: https://chromium-review.googlesource.com/1061513Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The term memory usually refers to the wasm memory. In the {NativeModule}, we store pools for allocated and available code space. This CL changes naming to make clear that this is code space and not memory. R=titzer@chromium.org Bug: v8:7754 Change-Id: I195bf5c9227ad246af302ae1e98f9c839a02adbf Reviewed-on: https://chromium-review.googlesource.com/1061495Reviewed-by: -
Andreas Haas authored
In WebAssembly benchmarks I saw Binop instructions with 6 inputs. We don't know how many inputs there can actually be, so we conservatively increase the number to 8 now. R=jarin@chromium.org Bug=chromium:842501 Change-Id: Id087481e7e524006c2f03fc545f9e35d1cad1fe8 Reviewed-on: https://chromium-review.googlesource.com/1061114Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53207}
-
Benedikt Meurer authored
The CallIC class is obsolete and unused for a long time, and the IC::FrameDepth was only there to support the additional frame that was imposed by the CallFunctionStub. All of that is long gone, so we don't need that here. Bug: v8:7754 Change-Id: Ic82f68b325e3e10e285e30111053ffffd547f965 Reviewed-on: https://chromium-review.googlesource.com/1061354Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53206}
-
Marja Hölttä authored
BUG=v8:7490 Change-Id: I53888e391a0ad25407e59431b2fffbd7cacf5273 Reviewed-on: https://chromium-review.googlesource.com/1060060 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b61b6b6..03f39fd Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/0b71401..e754647 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e853531..d8600cc Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d1de725..8de3800 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/51de78a..a67a084 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I09efa7ed11e7f575c4f02746b39e151ebf8c2698 Reviewed-on: https://chromium-review.googlesource.com/1061093 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#53204}
-
Daniel Clifford authored
Including specialization, e.g.: // Declare parameterized generic macro GenericMacroTest<T: type>(param: T): Object { return Undefined; } // Declare specialization of generic GenericMacroTest<Object>(param: Object): Object { return param; } ... assert(GenericMacroTest<Smi>(0) == Undefined); assert(GenericMacroTest<Smi>(1) == Undefined); assert(GenericMacroTest<Object>(Null) == Null); assert(GenericMacroTest<Object>(False) == False); ... Known issue: specialization doesn't rigorously checked to verify that specialization signature precisely matches generic declaration. Change-Id: I9d9d96da4c5c8c9a76550844680e9e133a5edaed Reviewed-on: https://chromium-review.googlesource.com/1043986 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53203}
-
Camillo Bruni authored
As my mum used to say: When it comes to flushing, later is better than early. Tentative fix for Android invoke crashers with write protection code enabled. Bug: chromium:842862 Change-Id: Ib37115883a6fa615c9514aeb543dc3527335803a Reviewed-on: https://chromium-review.googlesource.com/1059673Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This adds a filter option for --trace-turbo, --trace-turbo-graph and --trace-turbo-scheduled. The filter is a pattern that matches function names in this way: "*" all; the default "-" all but the top-level function "-name" all but the function "name" "" only the top-level function "name" only the function "name" "name*" only functions starting with "name" "~" none; the tilde is not an identifier Bug: v8:7761 Change-Id: I7e8e726023f2c72754b0dd691d790af20b022fd3 Reviewed-on: https://chromium-review.googlesource.com/1059774Reviewed-by:
-
Miran.Karic authored
The problem occurs when getting an unused register causes spilling, but the generated code is not executed because of a branch, resulting in loss of data. BUG= TEST=cctest/test-run-wasm/RunWasmLiftoff_I64Sh* Change-Id: Icdb897df42059ed27bec57fcf91cc8338e4598f3 Reviewed-on: https://chromium-review.googlesource.com/1060213Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#53200}
-
Simon Zünd authored
This CL consolidates CopyFromPrototype and RemoveArrayHoles into a single runtime function. It also creates two small helper functions that are needed in both pre-processing steps. Additionally it removes the return value from CopyFromPrototype since it is no longer needed (it was previously used by a sort post- processing step that no longer exists). Bug: v8:7382 Change-Id: I7f9b00c1bc639d2118fdecef9c3b45c2cf010310 Reviewed-on: https://chromium-review.googlesource.com/1051887 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
ray glover authored
- I think d8's ability to load es6 modules is important enough to document through the CLI - I also tried to simplify the d8/shell CLI synopsis This is my first patch; I can't run the automated test suite. Change-Id: I6376542f57f11dd8ec53be9b53f3d17d46a86fed Reviewed-on: https://chromium-review.googlesource.com/1056530Reviewed-by:
-
Vaclav Brozek authored
Array.indexOf accepts an optional fromIndex argument. When non-negative, this argument restricts the searched indices to those starting at fromIndex: [1, 2, 1].indexOf(1,1) == 2 When negative, it is meant to be added to the array length to provide such initial index for the search: [1, 2, 1].indexOf(1, -2) == 2 This transformation has been done by the non-optimised builtin but not by the reducer. The CL adds this construction to the reducer. Bug: chromium:842612 Change-Id: I0ff089997f4ebb4dc3c2923e52c382a8a96cd711 Reviewed-on: https://chromium-review.googlesource.com/1059628Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#53197}
-
Dan Elphick authored
Adds Page::MakeHeaderRelocatable that clears pointers to objects outside the space. In this case relocatable means the entire page heading is position independent in memory, meaning it could be saved to disk and reloaded at a different memory location in a new process without there being any invalid pointers. Currently this only affects mutex_, locate_tracker_ and reservation_. Additionally makes VerifyHeap work when there's no mutex in a Page. This is just a stepping stone to making the Pages headers relocatable since heap_ and owner_ still point out of the Page. Also removes the empty ReadOnlySpace destructor. Bug: v8:7464 Change-Id: Ife3c06575fa73a5818c4991fb9bec30a5f43901d Reviewed-on: https://chromium-review.googlesource.com/1054879Reviewed-by:
-
Georg Neis authored
This function didn't account for addresses of api-provided external references, leading to out-of-bound reads on external_reference_table. (This happened to me when printing a code object in gdb, I'm not sure how to easily test it.) Also remove an unused method from the private Value class. R=jgruber@chromium.org Change-Id: Id14fed3fb3866df750bcad8f4a02c61748b07ad3 Reviewed-on: https://chromium-review.googlesource.com/1060035Reviewed-by:
-
jgruber authored
Code generation introduces indirections if a builder exists (and the serializer is active). These indirections are not necessary outside of embedded builtins (e.g. in bytecode handlers), so let's reduce its lifetime. Bug: v8:6666 Change-Id: I57207012997786f599f79f0982da61eea26f3e22 Reviewed-on: https://chromium-review.googlesource.com/1059114 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
- 15 May, 2018 7 commits
-
-
Nebojsa Ciric authored
https://github.com/tc39/proposal-intl-locale Rename locale property to baseName to better reflect the intented use case and the change in spec. TBR: bmeurer@chromium.org Bug: v8:7684 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I91b630b49ce73abcebd6040ec968c91d75cff879 Reviewed-on: https://chromium-review.googlesource.com/1014411 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Wez authored
ArrayBuffer memory allocated off-heap was previously tracked by a test- only retained_size() field on each LocalArrayBufferTracker. Changes in off-heap ArrayBuffer memory usage are now reported to the Space with which the ArrayBuffer is associated, so that the value is cheaply available to include in e.g. GC limit calculations, via a new getter, ExternalBackingStoreBytes(). Changes to external ArrayBuffer backing-store allocations are tracked in an AtomicNumber associated with each Space, to allow for ArrayBuffers being concurrently moved or freed from multiple Pages in the same Space during sweeps & compactions. Bug: chromium:837583 Change-Id: I8b1b6addd5cd05533d8da55ca813e134bc36e181 Reviewed-on: https://chromium-review.googlesource.com/1052347 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#53192}
-
Clemens Hammacher authored
With the introduction of a jump table, call targets will not be {WasmCode} objects any more. Instead, we just call any {Address}. This CL does not change anything yet, but changes interfaces to accept an {Address} instead of {WasmCode*}. R=titzer@chromium.org Bug: v8:7758 Change-Id: Id299738bb7cc6a1891e4a03d7f67c24cde6d1699 Reviewed-on: https://chromium-review.googlesource.com/1058793 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
We were always using the instance we were currently building. If the start function is an exported wasm function of another instance, use the exporting instance instead. R=titzer@chromium.org Bug: chromium:843120 Change-Id: I141d272b947bef8e903be7208ddf6ce344e754c4 Reviewed-on: https://chromium-review.googlesource.com/1059620 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
jgruber authored
The (currently four, soon five) RelocIterator constructors contain basically identical logic. Refactor that into a basic version that all other constructors call. Bug: v8:6666 Change-Id: Ice7b4891d5e539ff6fe63337fc52d480d85dc270 Reviewed-on: https://chromium-review.googlesource.com/1059109 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Igor Sheludko authored
In particular: * number of pointer fields * number embedder fields * number boxed fields * number of unboxed double field * number of raw data fields Bug: v8:7703 Change-Id: I22a310d941317a0f34f67536e55fbfab5f5354cd Reviewed-on: https://chromium-review.googlesource.com/1056532Reviewed-by:
-
Clemens Hammacher authored
Since the code around that is quite fragile, and I plan to refactor it, just add some tests to ensure that everything is and keeps working as intended. R=mstarzinger@chromium.org Bug: v8:7758 Change-Id: Ib3814b93b465286d70b5669ed0161eecb9fc925a Reviewed-on: https://chromium-review.googlesource.com/1059616Reviewed-by:
-
