- 27 Apr, 2018 15 commits
-
-
Clemens Hammacher authored
This adds support for f64.min and f64.max, implemented on ia32, x64, mips and mips64. R=ahaas@chromium.org Bug: v8:6600 Change-Id: Ib4383df08692c76df5861fe71a96c4354fdf10c1 Reviewed-on: https://chromium-review.googlesource.com/1028235 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#52838}
-
Georg Neis authored
R=sigurds@chromium.org Bug: v8:7570 Change-Id: I3f077940117467be98fbb3c2a30684af8eaaf801 Reviewed-on: https://chromium-review.googlesource.com/1032432 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52837}
-
sreten.kovacevic authored
Fix initial implementation of min/max f32 instructions. Bug: v8:6600 Change-Id: Icb30515b692caef2c33bd85f468e83c17cdef2a3 Reviewed-on: https://chromium-review.googlesource.com/1030493Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Cr-Commit-Position: refs/heads/master@{#52836}
-
Ben L. Titzer authored
R=ahaas@chromium.org Bug: v8:7570 Change-Id: I5327d1b8e2f2bf4c1538f565442305a0e1f05b65 Reviewed-on: https://chromium-review.googlesource.com/1032550Reviewed-by:
-
Michael Achenbach authored
See referenced bugs for links. NOTRY=true Bug: v8:5193,v8:7702 Change-Id: I380479405f46cfc32d6cfa728fb86297f6d4f43c Reviewed-on: https://chromium-review.googlesource.com/1032436Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52834}
-
Michael Achenbach authored
This adds presubmit checks and documentation for the features added on infra side in https://crrev.com/c/1019080. NOTRY=true Bug: chromium:830557 Change-Id: If3808f5931f7b1043a8a80c03a293df4602ce758 Reviewed-on: https://chromium-review.googlesource.com/1021140Reviewed-by:
-
Clemens Hammacher authored
Both macros currently call a function with individual CHECKs, which makes error messages only show that one part of the equality check (and not the the actual float values), and hides the actual location of the check. This CL refactors this such that the actual value is shown (just as with other CHECK_EQ macros) and it shows the right file name and line number. R=ahaas@chromium.org Bug: v8:7570 Change-Id: I198e73c053178a09f14330a18069463760693f81 Reviewed-on: https://chromium-review.googlesource.com/1027879Reviewed-by:
-
Ben L. Titzer authored
In the case of an indirect call to an imported function, the target instance stored in the IFT was actually wrong. Bug: chromium:834619 Change-Id: Id2ac4158335ecf2b58e1983ce37df852a9ebd1b2 Reviewed-on: https://chromium-review.googlesource.com/1030174 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52831}
-
Marja Hölttä authored
It's old & not used recently & obsolete. It was mainly used for measuring the effect of preparse data, which we no longer have. BUG=v8:7570 Change-Id: Ic31958e736fbf9645e014f6ef61dd6cf72a42c76 Reviewed-on: https://chromium-review.googlesource.com/1032390Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#52830}
-
Marja Hölttä authored
Calls a function defined in map-inl.h which mark-compact.h is not allowed to include. BUG=v8:7490,v8:5402,v8:7570 Change-Id: I51cef646fc2b650208d4e59b92bcd1e406ddd7fd Reviewed-on: https://chromium-review.googlesource.com/1032332Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#52829}
-
Michael Achenbach authored
This adds parts of Chromium's PanProjectChecks. We don't add all yet as there is to much chance for the checks to fire on files later. We first need to find a way to run the checks on all files (not only changed ones). NOTRY=true Bug: v8:7689 Change-Id: I747b49a9a362cf76f329e7f743545c6e6cb56f85 Reviewed-on: https://chromium-review.googlesource.com/1029854Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52828}
-
jgruber authored
The test is flaky on arm in --optimize-for-size. NOTRY=true Bug: v8:7605 Change-Id: I6219442545244bb0c07f8b028668f41602a83b30 Reviewed-on: https://chromium-review.googlesource.com/1032331 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52827}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/403c903..70ef8f2 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/dc970d3..846cec5 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/4bd8c46..a6f06bf Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/abe5e4f..ec200e7 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Icdef510ea71b63f7dd748e72e85a494ebf790c39 Reviewed-on: https://chromium-review.googlesource.com/1031910Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#52826}
-
Jakob Kummerow authored
When collecting the values of an object with Smi or Object elements kind, there are no allocations, so we don't need to create a short- lived handle for each value. This gives a small performance benefit in general, and in particular on ia32 by reducing register pressure causes clang to spill less, which fixes the regression in the issue mentioned below. Bug: chromium:833591 Change-Id: I5eb0c6164b2972306ce965ec101687cab486bf0d Reviewed-on: https://chromium-review.googlesource.com/1029417 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#52825}
-
Jakob Kummerow authored
There is no need to remove an object pointer's heap object tag when all we want is the Page that it's on. Also, apply to IncrementalMarking's writebarrier the optimization that crrev.com/e570e673 brought to the old-to-new barrier. Change-Id: Ic9328d7d6f5c01073288a3e87931ea6095750740 Reviewed-on: https://chromium-review.googlesource.com/1029413 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52824}
-
- 26 Apr, 2018 25 commits
-
-
Jungshik Shin authored
Not all 2 or 3 letter language codes are canonical. Some of them need to be canonicalized. Specifically, exclude {jw,ji,iw,in} and all three-letter codes from the fast path except for 'fil'. {jw,ji,iw,in} are deprecated ISO 639 codes for {Javanese, Yiddish, Hebrew, Indonesian}. They should be canonicalized to {jv,yi,he,id}. So, do not return early in the fast path, but pass it down to the full canonicalization. In addition, there are 70+ deprecated 3-letter codes that need to be replaced by their modern equivalents. Instead of checking and replacing in v8, just pass them to ICU to handle. Along with the following ICU change, two more tests will pass. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1026797 These two tests still fail because of the disagreement between ICU and the test expectations about 5 grandfathered tags with no preferred value (e.g. i-default, zh-min, cel-gaulish). 'intl402/Intl/getCanonicalLocales/canonicalized-tags' 'intl402/Intl/getCanonicalLocales/preferred-grandfathered' Bug: v8:5693, v8:7669 Test: test262/intl402/language-tags-canonicalized.js Test: test262/intl402/Intl/preferred-variants.js Test: intl/general/language_tags_with_preferred_values.js Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ide7e9c90ac046859604c7b71c641f84ce9c64be5 Reviewed-on: https://chromium-review.googlesource.com/1023379Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52823}
-
Ben Smith authored
The new spec has two arguments, the first is the global descriptor, and the second is the initial value: new WebAssembly.Global({type: i32}, 42); If the initial value argument is omitted, the value is set to 0. Bug: v8:7625 Change-Id: I679d4b7c49c69ec7ffcdfeb8ae506fa7ab9bba95 Reviewed-on: https://chromium-review.googlesource.com/1028847Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#52822}
-
Kim-Anh Tran authored
Top-tier code needs to be explicitly logged after compilation. Change-Id: Ic3c54ff4b7bddd44516a611398b7373fe0acc8d4 Reviewed-on: https://chromium-review.googlesource.com/1030391Reviewed-by:
-
Ben L. Titzer authored
This CL simplifies and extends the implementation of Managed<T> and now uses a std::shared_ptr<T> underneath in order to offer cross-isolate management of C++ allocated memory. R=mstarzinger@chromium.org CC=ulan@chromium.org Bug: v8:7424 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id43a26f565677e8c9cdfd73810568d4f2b1871fe Reviewed-on: https://chromium-review.googlesource.com/1028190Reviewed-by:
-
jgruber authored
This is a reland of f5d30851 Original change's description: > [builtins] Introduce further constant & external reference indirections > > This introduces further indirections for embedded constants and > external references for builtins generated by the macro-assembler. > The used mechanisms (LookupConstant and LookupExternalReference) are > identical to what we already use in CSA. > > Almost all builtins are now isolate-independent in both release and > debug modes. snapshot_blob.bin is roughly 670K smaller in embedded > builds vs. non-embedded builds, while libv8.so is roughly 280K larger. > > Bug: v8:6666 > Change-Id: I7a6c2193ef5a763e6cf7543dd51597d6fff6c110 > Reviewed-on: https://chromium-review.googlesource.com/1006581 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52810} TBR=mstarzinger@chromium.org Bug: v8:6666 Change-Id: I73dfe207f2c5f79a9a06c165c75f5619e88a5a17 Reviewed-on: https://chromium-review.googlesource.com/1030550Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52819}
-
Alexey Kozyatinskiy authored
This is a reland of 436faae0 Original change's description: > [inspector] added timeout for Debugger.evaluateOnCallFrame method > > R=dgozman@chromium.org,yangguo@chromium.org > > Bug: none > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I569899f245190ca2fa720bdb837db1263e8058d5 > Reviewed-on: https://chromium-review.googlesource.com/1023035 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52798} Bug: none Change-Id: I91219382b5dc45b54dd8e5c64d9f0d11c849b9c8 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1030510 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Yang Guo authored
R=jgruber@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I62955f95812a2c6ac04599c437971863a73af66d Reviewed-on: https://chromium-review.googlesource.com/1014103Reviewed-by:
-
sreten.kovacevic authored
Implement emit_jump when target is in register. Bug: v8:6600 Change-Id: Idd8fc739ac9997cad53feffdfcee5ae25d9ad6ee Reviewed-on: https://chromium-review.googlesource.com/1030453Reviewed-by:
-
Vincent Belliard authored
When a liftoff function bails out after generating some constant pool, this avoids to trigger a check in the Assembler destructor. Bug: v8:6600 Change-Id: I79c595605bc0add1f3f5617ac7feedf162081d8a Reviewed-on: https://chromium-review.googlesource.com/1026647Reviewed-by:
-
Ivica Bogosavljevic authored
In liftoff, call to PrepareCallCFunction was using at as scratch register. This is a very bad idea, since at is later used in underlying macro assembler TEST=cctest/test-run-wasm-64/RunWasmLiftoff_Regression_6858 Change-Id: Ifbc43678731d2833d2faa2f20fe79ea9e3089002 Reviewed-on: https://chromium-review.googlesource.com/1030430Reviewed-by:
Sreten Kovacevic <sreten.kovacevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#52814}
-
jgruber authored
This reverts commit f5d30851. Breakages: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/20370 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/21174 TBR=yangguo@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Change-Id: Ic4d28fccf647aadcac0a60430b7fb66d22ce4577 Reviewed-on: https://chromium-review.googlesource.com/1030431Reviewed-by:
-
Jakob Gruber authored
This reverts commit 2f0a78ab. Reason for revert: Test fixed by https://chromium-review.googlesource.com/1030211. Original change's description: > [test] Disable pause-on-oom in no_snap > > > TBR=machenbach@chromium.org > > Bug: v8:7631 > No-Tree-Checks: true > No-Try: true > Change-Id: Iace8fae7fcbdd1766394ee30d0c1e54f3a29e2b9 > Reviewed-on: https://chromium-review.googlesource.com/1027852 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52780} TBR=machenbach@chromium.org,ahaas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7631 Change-Id: I42bd9d251eb82b2e49e45756118d7dde8f99536d Reviewed-on: https://chromium-review.googlesource.com/1030390Reviewed-by:
-
jgruber authored
Intl builtins must stay behind V8_INTL_SUPPORT. This fixes: ci.chromium.org/buildbot/client.v8.ports/V8%20Mips%20-%20builder/16733 TBR=yangguo@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Change-Id: I001df26585e376c6e242ece88612e10417529037 Reviewed-on: https://chromium-review.googlesource.com/1030272Reviewed-by:
-
jgruber authored
This introduces further indirections for embedded constants and external references for builtins generated by the macro-assembler. The used mechanisms (LookupConstant and LookupExternalReference) are identical to what we already use in CSA. Almost all builtins are now isolate-independent in both release and debug modes. snapshot_blob.bin is roughly 670K smaller in embedded builds vs. non-embedded builds, while libv8.so is roughly 280K larger. Bug: v8:6666 Change-Id: I7a6c2193ef5a763e6cf7543dd51597d6fff6c110 Reviewed-on: https://chromium-review.googlesource.com/1006581 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
jgruber authored
This should fix the recent frequent pause-on-oom failures. The callback attempted to create a handle without a HandleScope. Bug: v8:7631 Change-Id: Id15ba287896d62d3205585d14204f0c92a8823f8 Reviewed-on: https://chromium-review.googlesource.com/1030211Reviewed-by:
-
Peter Marshall authored
When running this test locally, the OptimizeFunctionOnNextCall call fails, because the line above has no semicolon, and automatic insertion doesn't help, probably because of the % sign. The test still runs, but the first call after level1() fails, meaning the inlining does not happen. Change-Id: Icd2d08e676ea3cade63d4e12277748a447e410fc Reviewed-on: https://chromium-review.googlesource.com/1030210Reviewed-by:
-
Stephan Herhut authored
This adds support for the I32AtomicCompareExchange operations in the interpreter. Also, the interpreter will now fail if it encounters an unknown opcode from the atomic prefix. Bug: chromium:826069 Change-Id: Iec1742271f4fdd83fcaa09ca72c24d1cf8c58835 Reviewed-on: https://chromium-review.googlesource.com/1029867Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#52807}
-
sreten.kovacevic authored
Implement float to i32/u32 conversion on mips. Also, fix order of arguments in some macro-assembler instructions used for these conversions. Bug: v8:6600 Change-Id: I94c91f8ac7796ac66fb3cf0129a2a27c1a6ec336 Reviewed-on: https://chromium-review.googlesource.com/1028232 Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/358d25a..403c903 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/8febfea..ab7b6a7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f718fb1..dc970d3 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/b640d87..4bd8c46 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/aff99f5..e4194dc Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5395a74..abe5e4f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I8b2b34357451a7c1f71327e7cf633dc73aea5f72 Reviewed-on: https://chromium-review.googlesource.com/1029740 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
-
Camillo Bruni authored
- display enum cache - display capacity Change-Id: I79eed54af36b1fbb5435d96b650c0823be380e20 Reviewed-on: https://chromium-review.googlesource.com/1027874 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#52804}
-
Clemens Hammacher authored
This adds support for f32.min and f32.max, implemented on ia32, x64, mips and mips64. R=ahaas@chromium.org Bug: v8:6600 Change-Id: If73abf3cf46011ba84158ed2ec02d074adcf4ba2 Reviewed-on: https://chromium-review.googlesource.com/1027841 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80b7a3c..358d25a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I31cde2d9d9ffbfd4954038d36fc8bfd2f726151d Reviewed-on: https://chromium-review.googlesource.com/1012970Reviewed-by:
-
Stephan Herhut authored
For wasm memory buffers, we normally require the memory to be allocated via WebAssembly.Memory, which will set a is_wasm_memory flag and register the memory with the wasm allocation tracker. This CL weakens that requirement in a DCHECK to allow for running experimental threaded applications even though the is_wasm_memory flag is not currently propagated via postMessage. Bug: chromium:836800 Change-Id: I4613b8651423307ce4cd466c0df28fc43244ec4f Reviewed-on: https://chromium-review.googlesource.com/1027813 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#52801}
-
Michael Achenbach authored
This reverts commit 436faae0. Reason for revert: Introduces flakes: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/24482 https://build.chromium.org/p/client.v8/builders/V8%20Win32/builds/13557 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/25210 Original change's description: > [inspector] added timeout for Debugger.evaluateOnCallFrame method > > R=dgozman@chromium.org,yangguo@chromium.org > > Bug: none > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I569899f245190ca2fa720bdb837db1263e8058d5 > Reviewed-on: https://chromium-review.googlesource.com/1023035 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52798} TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I63ee0d19642856a7c0c2128bfa4c4620974d1919 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1029910Reviewed-by:
-
Sigurd Schneider authored
This CL also removes the JSBuiltinReducer, which is no longer needed. Bug: v8:7340, v8:7250 Change-Id: I28896f6ce0d352047ea1cb7ea6de490818840faf Reviewed-on: https://chromium-review.googlesource.com/1027853 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52799}
-
