- 28 Jan, 2021 32 commits
-
-
Junliang Yan authored
Change-Id: I7f1d5e39033957410a8f3601100c7b7c5839271f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2657475Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72414}
-
Michael Lippautz authored
Allows for prohibiting GCs and will result in a crash in case a GC finalization event is triggered. Complements NoGarbageCollectionScope which ignores GC finalization events. Bug: chromium:1056170 Change-Id: Ie2a72a8675462b24692225af17c8f284318337ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656260Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72413}
-
Michael Lippautz authored
Embedders forward the Value in TraceEphemeron as Member reference (as depicted in the API docs). Add TraceTrait<Member<T>> that forwards to TraceTrait<T> accordingly, supporting the intended use case. Bug: chromium:1056170 Change-Id: I3b247cb3553ae34d9ff5393aefeaec24068e78c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656255 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Marja Hölttä authored
The original commit implementing private accessor propertiers (*) claims it's not a thing, but it is. (*) https://chromium-review.googlesource.com/c/v8/v8/+/1695205/11/src/interpreter/bytecode-generator.cc#3959 Bug: v8:11360, v8:8330 Change-Id: If497f2b6a77dc28e4ade4ef78d901299f4e37593 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652495Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Joyee Cheung <joyee@igalia.com> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#72411}
-
Clemens Backes authored
1) Wasm code is not associated with a Code object, hence WasmFrame::unchecked_code will always return a null object. Hence we can use the default implementation from TypedFrame and avoid the lookup on the heap which will always fail. 2) InternalFrame inherits from TypedFrame, hence can also reuse the unchecked_code implementation from TypedFrame. 3) Use "{}" instead of "Code()" to return "nothing". R=jkummerow@chromium.org Bug: v8:11074 Change-Id: I142d2f21c05bf87cafa5ba6e7f463510be6c70bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653229Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72410}
-
Camillo Bruni authored
Fix filename creation when printing RCS to files. Change-Id: I04929366496ce2ac52d96540c2d41f753b293f24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650209Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#72409}
-
Manos Koukoutos authored
As per the latest wasm-gc spec, type checks are only allowed from subtypes of dataref and funcref. To cast from a more general type, specialized classification instructions need to be used (will come later). Bug: v8:7748 Change-Id: I29de48f445d652c5fc4e266d82e7d2e32cd7b6d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649262 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Jakob Gruber authored
They've started failed, and no work is planned for the foreseeable future. Bug: v8:8888 Change-Id: I89dfa8f972a5bffa2bbb09c7a6ca56a0c4da9a02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656316 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#72407}
-
Milad Fa authored
Port 3965dcd5 Original Commit Message: This very slightly improves the performance of bytecode array visitors. R=verwaest@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I7952fcacc72f4166c73885fd715950b319458209 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656455Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#72406}
-
Manos Koukoutos authored
As per the latest wasm-gc spec, all immediate arguments are removed from ref.cast and ref.test. Bug: v8:7748 Change-Id: I5839103276c4c5d51f3fa82a21cf2447cbb8ecaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649261 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Camillo Bruni authored
ALmost all tools have migrated to .mjs modules. Bug: v8:10667 Change-Id: I95f7c4a31a721be3000c990bdac1c4eb0779b693 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2642460Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#72404}
-
Benedikt Meurer authored
This adds a [[WebAssemblyMemory]] internal property to ArrayBuffer and SharedArrayBuffer instances that are owned by WebAssembly.Memory objects. This allows the devtools-frontend to find the WebAssembly.Memory for any given ArrayBuffer, making it possible to properly support WebAssembly.memory.grow() eventually, but also showing a reasonable tab title. Before: https://imgur.com/hod9jPR.png After: https://imgur.com/v195VoC.png Bug: chromium:1171621, chromium:1171619, chromium:1166577 Change-Id: Ife22cabdfcf54ab30c234ea4ca86bfbb711ab2f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653155 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72403}
-
Benedikt Meurer authored
Previously we had the debugger / inspector support declared in debug-interface.h, but the implementation was sprinkled all across api.cc, which was quite messy. This moves the relevant macros and other bits into api-macros.h (with api-macros-undef.h to support jumbo builds), and moves the debugger interface implementation to src/debug/debug-interface.cc. Bug: chromium:1162229 Change-Id: If2698cba7bcc0b54b0f889220588ec214405848b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656256 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#72402}
-
Thibaud Michaud authored
This is a reland of a80d51d4 There were two main issues: - Liftoff did 32 bit addition to get the offset, which overflowed and created a valid address where an OOB was expected - The access mode and landing pad was missing for SIMD load and store instructions Also fixed the macros to disable trap handlers from simulator builds. Original change's description: > [wasm][mac][arm64] Enable OOB trap handler > > R=ahaas@chromium.org,mark@chromium.org,mseaborn@chromium.org > > Bug: v8:11098 > Change-Id: Ic4eb02a96805e49da71f301269567a6e0ac1b843 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519555 > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72136} Bug: v8:11098 Change-Id: I2ebe434577f2cbe168f0bccf2936f69ca211e3c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2637223Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#72401}
-
Dominik Inführ authored
10ms is most likely too short, this also forces us to rename those metrics. Also rename the corresponding tracing events. Bug: v8:10315 Change-Id: I42fb1572b150f15cf12c2b02444f015fae349344 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652494Reviewed-by:
-
Manos Koukoutos authored
As per latest wasm-gc spec, the data heap type is a subtype of eq and a supertype of all array and struct types. The heap type expected for arrays and structs when interacting with JS changes from eq to data. Bug: v8:7748 Change-Id: Idd1670b9e47acc95c098559e674c629ea44ca49d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649044 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Chong Gu authored
Needed since default manifest assignment will be put into the test() template in https://chromium-review.googlesource.com/c/chromium/src/+/2596114 Bug: chromium:1132878 Change-Id: I2475280c590f67cc88bcf6e877cab347079d734c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650765 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Clemens Backes authored
The "noexcept" annotation is part of the type since C++17, so we cannot just change v8.h to add the annotation everywhere. So instead ignore missing V8_NOEXCEPT annotations in api.cc R=marja@chromium.org CC=jdoerrie@chromium.org No-Try: true Bug: v8:8616 Change-Id: I8f68a6d20653ee8c0e3d995cf585b36cbc15c5f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655446 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Michael Lippautz authored
This allows construction and destruction of empty Persistent and friends, which simplifiest the use for embedders. Bug: chromium:1056170 Change-Id: I4286639aa5d50f9f98654b859de10bb80cbada21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655505 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
As per the latest wasm-gc spec, rtts now have optional depth, with (rtt n type) <: (rtt type) for every depth n. Liftoff compilation for type checks without depth are not supported yet. Bug: v8:7748 Change-Id: I4971875e6a42db6d333b61ca5e2996e875f39f60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649043Reviewed-by:
-
Omer Katz authored
Update the MetricRecorder struct to have a similar structure and similar fields to the GC struct defined in v8-metrics.h Bug: chromium:1056170 Change-Id: Ieb77412476353557134aeac5cf8f66ab257e22dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653236Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Marja Hölttä authored
This reverts commit 1b4811f7. Reason for revert: makes "git cl upload" fail (the change related to files_to_skip) Original change's description: > [debug][api] Move debugger support to debug-interface.cc. > > Previously we had the debugger / inspector support declared in > debug-interface.h, but the implementation was sprinkled all across > api.cc, which was quite messy. This moves the relevant macros and > other bits into api-macros.h (with api-macros-undef.h to support > jumbo builds), and moves the debugger interface implementation to > src/debug/debug-interface.cc. > > Bug: chromium:1162229 > Change-Id: I6965ebf2301459c89e3217bd87396ec353d814e9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653154 > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72392} TBR=yangguo@chromium.org,bmeurer@chromium.org Change-Id: Ib9460709df799cd63b221f9f30dc33dff53075bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1162229 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655508Reviewed-by:
-
Benedikt Meurer authored
Previously we had the debugger / inspector support declared in debug-interface.h, but the implementation was sprinkled all across api.cc, which was quite messy. This moves the relevant macros and other bits into api-macros.h (with api-macros-undef.h to support jumbo builds), and moves the debugger interface implementation to src/debug/debug-interface.cc. Bug: chromium:1162229 Change-Id: I6965ebf2301459c89e3217bd87396ec353d814e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653154 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Marja Hölttä authored
This reverts commit f6450b97. Reason for revert: ClusterFuzz bugs Original change's description: > Reland [super] Store home object in Context instead of JSFunction > > 1) Computed property keys (esp functions in them) shouldn't be inside > the object literal scope. > > 2) I was using an imprecise "maybe uses super" and storing it to > preparse data. This won't fly, since it pollutes sister scopes and > leads to confusion wrt whether an object literal needs a home object > or not. Made it precise (mostly cancelling changes in the original CL). > > 3) PreParser::NewSuperPropertyReference was creating a VariableProxy for > this_function (which made it used) -> inconsistent scopes between > parsing and preparsing. > > 4) MultipleEntryBlockContextScope was messing up the accumulator > > Original: https://chromium-review.googlesource.com/c/v8/v8/+/2563275 > > This saves memory (the home object doesn't need to be stored for each > method, but only once per class) and hopefully makes the home object > a constant in the optimized code. > > Detailed documentation of the changes: > https://docs.google.com/document/d/1ZVXcoQdf9IdMsnRI9iyUjyq9NDoEyx9nA3XqMgwflMs/edit?usp=sharing > > Bug: v8:9237, chromium:1167918, chromium:1167981, chromium:1167988, chromium:1168055 > Change-Id: I4f53f18cc18762c33e53d8c802909b42f1c33538 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2637220 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72169} TBR=marja@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9237 Bug: chromium:1167918 Bug: chromium:1167981 Bug: chromium:1167988 Bug: chromium:1168055 Bug: chromium:1171195 Bug: chromium:1171600 Change-Id: I15209f50c3fc8acf385a23f031ebb64139e2f519 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653158Reviewed-by:
-
Camillo Bruni authored
- Deduplicate entries when writing multiple runs into a single .txt file - Add support to load multiple files directly via url params - Display graphs after appending new files - Fix tracing .json import script Change-Id: I06349df57faf206d6a215cfc279c79d1f0dd684c No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650211 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#72390}
-
Jakob Gruber authored
--collect-heap-spill-statistics --concurrent-array-buffer-freeing --concurrent-store-buffer --es-staging --fast-math --gc-experiment-background-schedule --gc-experiment-reduce-concurrent-marking-tasks --minor-gc-parallel-marking --sodium Change-Id: I2cb2626473baef4b800b86e8acd5012b5b651758 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653228Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#72389}
-
LiuYu authored
Besides, change kSpeculationPoisonRegister from t3 to a7. Port: a1616e6f Bug: v8:7581 Change-Id: Id25850ddebce7250997e3b042ef094afd5d37d36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2651699Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72388}
-
Toon Verwaest authored
This very slightly improves the performance of bytecode array visitors. Change-Id: I39df381a26106b5576df74c8c204279b224a92af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653227 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Sami Kyostila authored
Bug: chromium:1006541 Change-Id: Ia3f1b16a4becd10bd4041f35e125aad7acc33949 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653235 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#72386}
-
Liu Yu authored
Besides, move load/store lane out of post-mvp. Port: 97a935ee Port: 848137c4 Change-Id: I8d98ed9949ba76648deefb1779057b76dff1304a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2654865Reviewed-by:
-
Sathya Gunasekaran authored
Looks like this was broken by the renaming in https://chromium-review.googlesource.com/c/v8/v8/+/2627309 Bug: v8:11361 Change-Id: I07c74a847171070a6a9296f3f6e1ef1f45002c66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2651700Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#72384}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fcaf1b1..5e38be7 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/71044df..e3db55b Rolling v8/test/test262/harness: https://chromium.googlesource.com/external/github.com/test262-utils/test262-harness-py/+log/4555345..278bcfa Rolling v8/third_party/aemu-linux-x64: DUWCHyibCTWCe-ijlAKpinTlXaJQW2jg8hs7uRUfK0gC..2AjFHxe4t1iSrrSx8ayS9uaUpVgbf4uevQoAj-Pt5_0C Rolling v8/third_party/android_ndk: https://chromium.googlesource.com/android_ndk/+log/27c0a8d..401019b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f8d79d2..9d5ec46 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6d0c0ff..9a18e37 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/899e183..2eefd9a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/eb5ab41..0d2b891 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I705e9f7527d2cd45e4dd7ff0b536ace8ee135b09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2654638Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72383}
-
- 27 Jan, 2021 8 commits
-
-
Ng Zhi An authored
vcvtdq2pd was incorrectly declared to take 3 operands, the use of the macro Cvtdq2pd meant that the call was vcvtdq2pd(dst, dst, src). This is an incorrect encoding. Our tests happen to pass because dst was xmm0, which made it accidentally correct. This fixes it by moving cvtdq2pd out of the macro list. Bug: v8:11265 Change-Id: I8b1baf4dd2c670021eafa76dc1a10b442f812805 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2654003Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72382}
-
Milad Fa authored
Port 848137c4 Original Commit Message: Define a new macro list, since this has 1 immediate operand (lane index) compared to other SIMD load/stores. Also remove all the ifdef guards. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Bug: v8:10975 Change-Id: I5eb08035c178808fb5033d001e0800956105c8f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2654186Reviewed-by:
-
Ng Zhi An authored
For ARM, factor the code sequence out into a macro-assembler function to allow sharing between TurboFan and Liftoff. Bug: v8:11215 Change-Id: Ib337e3f3dd90174b71a9bcd951b3779275c7465c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2648820 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Fa authored
Port 97a935ee R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I68e7e783c22a420d137ebf777f743780fc90e4d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653070Reviewed-by:
-
Milad Fa authored
Code fo Instruction Selection is added to the comments and should be added when opcode is moved out of being a prototype. Bug: v8:10983 Change-Id: I3d7a0435d7b7c8f21217863c3aa894ae5b90afae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653808Reviewed-by:
-
Ng Zhi An authored
Define a new macro list, since this has 1 immediate operand (lane index) compared to other SIMD load/stores. Also remove all the ifdef guards. Bug: v8:10975 Change-Id: Ib0a1f7bb6c4bdf83d81a65b4e02199b792d13837 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2645568Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72377}
-
Ng Zhi An authored
Bug: v8:11215 Change-Id: Ib91d8e4cb2cd72a779f498827e154173c97a85cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2648819 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Clemens Backes authored
Instead of updating the detected features set directly, use the synchronized {OnCompilationStopped} method. In order to avoid this error in the future, the whole {detected_features()} getter is removed, as it returns a pointer which can only be accessed when holding the mutex anyway. Also, the refactored code was the only user of this dangerous method. Drive-by: Pass the WasmFeatures set by value, since it's just an EnumSet. Drive-by 2: Remove a print line from the regression test which can be confusing if the test is picked up again by foozzie. R=ahaas@chromium.org CC=zhin@chromium.org Bug: v8:11357 Change-Id: I75b5c8f35983d2bc1fd2b61adcb2ecfc18564f39 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653226Reviewed-by:
-
