- 11 Sep, 2019 17 commits
-
-
Joyee Cheung authored
This patch uses a bit in the Variable bit fields to distinguish static private names from instance private names, so that we can check the conflicts of private accessors that are complementary but with different staticness in the parser, and use this information later when generating code for checking static brands for private method access. Design doc: https://docs.google.com/document/d/1rgGRw5RdzaRrM-GrIMhsn-DLULtADV2dmIdh_iIZxlc/edit Bug: v8:8330 Change-Id: I8d70600e594e3d07f77ea519751b7ca2e0de87b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781010Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#63677}
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:8519 Change-Id: I3c63637fb9cb694e4d50be2fded1dcc02de7f2ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796559 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63676}
-
Joshua Litt authored
Also converts ACP from a Cell to a PropertyCell. Bug: v8:9463 Change-Id: I6cd26d4e4fd8869a17bf75f83cc177524f8082d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795742Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#63675}
-
Igor Sheludko authored
... to make it "smi-corrupting" decompression-friendly. Also add a cctest for the CSA implementation. Bug: v8:9706 Change-Id: I1f1b0aa1b40832a0c2ce81658da316b3e442189c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796802Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:6949, v8:9396 Change-Id: I19b865bea9ebe40f8f96cd220963cd3181412c82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792906 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#63673}
-
Michael Lippautz authored
Do not assume that the MaybeHandle that is returned when fetching for a property is valid and instead check for its contents. Treat an empty handle as not finding the right property. Bug: chromium:1002827 Change-Id: Iac158086ec5f66cd9602f4a73ae78de367dd3e77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796556 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#63672}
-
Simon Zünd authored
This CL adds a test where we evaluate a variable that is context allocated (through the use of 'eval'), but not used by the closure. This did not work with the previous whitelist approach, but works now with the new blacklist approach (see https://crrev.com/c/1795354) Bug: v8:9482 Change-Id: I1e453dec0b624bf7e0312100e119d86c9c481ba9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796543 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63671}
-
Victor Gomes authored
From verwaest@ work on the Json's parser, we know that removing the allocation type argument when creating objects using the factory class increases performance. This will also allow us to optimise these functions in a latter CL. Change-Id: If78f62a63fe41453f4def8bea77b6eddc2ab7f36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792168Reviewed-by:
-
Santiago Aboy Solanes authored
functionality is: If rhs_is_smi is true, we are sure that rhs is a Smi. If rhs_is_smi is false, rhs might or not be a Smi. Therefore, rhs_known_smi fits better. Change-Id: Ie6dd0446ef85ba0730189e2012a21c24d1731b74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796551Reviewed-by:
-
Sigurd Schneider authored
Notry: true Notreechecks: true Change-Id: Ie15006dfd812a26486c7e2a5d09c713b92456ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796555 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:6949, v8:9396 Change-Id: If9fa66de4aecfe72c30ac81c563216fd5e057eb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792903 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL changes how variables are resolved during debug evaluate. We now re-parse the whole script when creating a ScopeIterator. This gives us accurate scope information for all parent scopes of the closure in which we stopped. Using this information, we build blacklists of stack-allocated variables. Each context on the chain in between the closure context up to the original native context is wrapped in a debug-evaluate context with such a blacklist attached. Variable lookup for debug-evalute contexts then works as follows: 1) Look up in the materialized stack variables (stayed the same). 2) Check the blacklist to find out whether to abort further lookup. 3) Look up in the original context. Steps 1-3 is repeated for each debug-evaluate context, since they mirror the original context chain. R=ulan@chromium.org, yangguo@chromium.org Change-Id: Ied8e5786772c70566da9627ee3b7eff066fba2b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795354Reviewed-by:
-
Mu Tao authored
Fix build errors introduced by commit af063685 and not fully fixed by commit db3cc4a2 Change-Id: Ifdc92f5d55061670127999058d374914985df762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795643Reviewed-by:
-
Mu Tao authored
Port ab0f9710 Original Commit Message: - Eliminates non-const reference parameters in test/cctest. Change-Id: I038314e0cc2b28e70e7ebcbd2d076ef62893285e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795646 Commit-Queue: Mu Tao <pamilty@gmail.com> Commit-Queue: Bill Budge <bbudge@chromium.org> Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#63664}
-
Michael Achenbach authored
Change-Id: I14103a02fa96f66f220559780e9d8ee116ff3e10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796548Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#63663}
-
Michael Achenbach authored
This reverts commit d72ae9ab. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Android%20Arm%20-%20builder/27990 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2d9fa32..0f7adef > > Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/74cfb57..cd73d21 > > Rolling v8/buildtools/linux64: git_revision:152c5144ceed9592c20f0c8fd55769646077569b..git_revision:ad9e442d92dcd9ee73a557428cfc336b55cbd533 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/884c81e..050abd8 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e5641be..d207f49 > > Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/3a45039..33a0d4f > > TBR=machenbach@chromium.org,tmrts@chromium.org > > Change-Id: I465ba35dd9e70e02c684687b656c34c5bd53ff23 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796705 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#63661} TBR=machenbach@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,tmrts@chromium.org Change-Id: I0ffabeb2df5a2949adf5ebb319bec20513a04c55 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796545Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2d9fa32..0f7adef Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/74cfb57..cd73d21 Rolling v8/buildtools/linux64: git_revision:152c5144ceed9592c20f0c8fd55769646077569b..git_revision:ad9e442d92dcd9ee73a557428cfc336b55cbd533 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/884c81e..050abd8 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e5641be..d207f49 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/3a45039..33a0d4f TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I465ba35dd9e70e02c684687b656c34c5bd53ff23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796705Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#63661}
-
- 10 Sep, 2019 23 commits
-
-
Frank Tang authored
Bug: chromium:997401 Change-Id: I7a78f4ad1fd05ab2bb2dbcd343060b2647aef4e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771954 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63660}
-
Michael Lippautz authored
Reuse the existing builtin and extension infrastructure to provide a garbage collection mechanism that allows for asynchronous execution. On --expose-gc, this changes the gc call to parse parameters the following: (1) Parse options when encountering an options object with known properties. (2) No parameters is parsed as {type: 'major', execution: 'sync'}. (3) Truthy parameter that is not setting options is parsed as {type: 'minor', execution: 'sync'}. (2) and (3) preserve backwards compatibility for existing callers as this may be used widely across various test and benchmarking infrastructures. Valid options: - type: 'major' or 'minor' for full GC and Scavenge, respectively. - execution: 'sync' or 'async' for synchronous and asynchronous execution respectively. Returns a Promise that resolves when GC is done when asynchronous execution is requested, and undefined otherwise. Note: This is implemented as builtin to avoid having any stack at all. This information is also passed to the embedder to allow skipping stack scanning. Change-Id: Ie5c9b6f0d55238abfeb9051ffa1837501d474934 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1793143 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: -
Santiago Aboy Solanes authored
Bug: v8:6949, v8:9396 Change-Id: I4c9382079190379661a26fbe6e1f4f6040a56d08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792902 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Gus Caplan authored
Bug: v8:9553 Change-Id: I376d4bd3d1554e1ed0bdeea79c47bd2a45e643d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795886 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#63657}
-
Z Nguyen-Huu authored
Bug: v8:8976 Change-Id: I281dc72dcdf03a1d05fdc632c9e9228d62bd85b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1783099 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Milad Farazmand authored
Port f72c844a Original Commit Message: Port f5ab7d38 Port 65f3861e Original Commit Message: In a new test suite: "wasm-api-tests", using a new binary "wasm_api_tests", powered by gtest/gmock (like unittests). Also fix a bunch of issues that these tests uncovered, mostly to ensure that the stack is walkable. R=miladfar@ca.ibm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Id52e771fee79210d6c295cecf56a322657cf2b8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795864 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#63655}
-
Clemens Hammacher authored
This reverts commit d7d25d2a. Reason for revert: crashes win32-debug: https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/21970 Original change's description: > [wasm] Patch jump tables in all code spaces > > If there are multiple code spaces, make sure to patch the jump tables > in all of them. > > R=mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: I2ec3d3de913b99623fd310004555337329588da0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1789289 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63651} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I4bdeb7394ebf002e3a84fececb0defba8bc9065d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9477 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796064Reviewed-by:
-
Igor Sheludko authored
This reverts commit 05d83a0e. Reason for revert: We passed the M78 branch point and should proceed testing the new elements kinds support. Original change's description: > Temporarily disable frozen/sealed elements kinds > > ... to prepare for merging this back to stable channel. > > Bug: chromium:992914 > Change-Id: Icbb257b5c02417d9222e60346575567360376264 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762021 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Auto-Submit: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63277} TBR=leszeks@chromium.org,ishell@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:992914, v8:996176 Change-Id: Iaa36c140c0c9c72ca0e58f5c3e7d4cad67027085 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795342Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#63653}
-
Leszek Swirski authored
Rather than duplicating code paths for in- and out-of-object stores, have one code path which checks whether it needs to load the property store (and change the storage location to the HeapNumber value for unboxed doubles). As a drive-by, change the representation dispatch into a switch, and inline the representation checks into that switch, to make explicit what checks for what and which paths transform the value. Also, TNodify some of the surrounding functions. Change-Id: Ia1bf698b4cec3ffce9aaa5732cda2e3be9efd8e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795345Reviewed-by:
-
Clemens Hammacher authored
If there are multiple code spaces, make sure to patch the jump tables in all of them. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: I2ec3d3de913b99623fd310004555337329588da0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1789289Reviewed-by:
-
Bill Budge authored
- Eliminates non-const reference parameters in src/objects. Bug: v8:9429 Change-Id: Ic39a59d54bda26c622db29f07143055c3cc6c7a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1794683Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=mslekova@chromium.org Change-Id: I3793426aaebd400ac93015b85ef11db5aecef52f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795357Reviewed-by:
-
Ana Peško authored
This CL changes how we handle the case when both --regexp-tier-up and --regexp-interpret-all flags are on. Previously, we had a CHECK that would crash if both flags were turned on, now we turn off the tier-up flag and print a warning message. Change-Id: I902a59cac9aaf316be05ab2acaee233aa32e023d Bug: chromium:1002242 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795353Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
After https://crrev.com/c/1793065 the test should be fast enough to execute it everywhere. R=mslekova@chromium.org Bug: v8:9696, v8:7783 Change-Id: I2485d703d6e973217eddde2f2814e31f7fcd8a61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795343 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Joshua Litt authored
Bug: v8:9463 Change-Id: I49d74c5103f4ee2e09114a609cffe82c838655dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792782Reviewed-by:
-
Simon Zünd authored
An upcoming CL will remove the COLLECT_NON_LOCALS support of the ScopeIterator. The DebugStackTraceIterator uses the list of non-locals to restore the receiver for arrow functions. This CL extracts the relevant logic into a small helper and calls it directly. Change-Id: Ia396fd599e41ca65810497d2f5228619cfdf7cc4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795347Reviewed-by:
-
Rong Wang authored
This CL is necessary for disabling write-barriers that involoves referencing pages via address arithmetic, which is required from third-party heap implementation. Change-Id: I1d3f572d48015e5c8cf691b2dc71a32834621c2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781008Reviewed-by:
-
Bill Budge authored
- Eliminates non-const reference parameters in test/unittests. Bug: v8:9429 Change-Id: Ia7b41482811183324a62859d27fc263e4032219a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1794802Reviewed-by:
-
Clemens Hammacher authored
Since we switched to C++14 now, we can use {std::make_unique} instead of our own {base::make_unique} from {template-utils.h}. R=mstarzinger@chromium.org, yangguo@chromium.org Bug: v8:9687 No-Try: true Change-Id: I660eb30038bbb079cee93c7861cd87ccd134f01b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1789300 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Thibaud Michaud authored
This is meant to check the performance impact of: https://chromium-review.googlesource.com/c/v8/v8/+/1776085/3 R=neis@chromium.org Bug: v8:9088 Change-Id: I8aad5272c1427b8bcaca02bdd0e51bf2779f7451 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781054Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#63641}
-
Suraj Sharma authored
based on dicussion at docs.google.com/document/d/1UzCOai9H07fYcSaSqvF_H7BS2-sF5q91A4r9O1mRnHc/ Bug: v8:9305 Change-Id: I7464d4267b6465cc02bc27dffb602c8871d846f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1696285 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Mythri A authored
We don't handle all cases for stores to typed arrays in the builtins related to storing a property. Bailout to runtime when storing into a typed array if the property is not found on the object. Bug: chromium:996161 Change-Id: I684c7c4f526b15cdfb5bfe3fd23218910486a59e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1789396 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6ff11c8..2d9fa32 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fcd6915..884c81e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/efce0d1..e5641be Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/3f05f65..3a45039 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I99a0be4d07f3e390d44aa11771d3c0dfc784f51a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1794125Reviewed-by:
-
