- 15 Jun, 2022 3 commits
-
-
Frank Tang authored
Design Document: https://docs.google.com/document/d/14zxGub6Os6nARzH6XstOZX05w2537sZo_ZSSlGjGpBM/edit# Bug: v8:10776 Change-Id: I506eadcf70f6855a79601a7cb1ce47849cfc066a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3594118Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#81168}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.duration.prototype.tolocalestring This does NOT implement the intl version of toLocale in (noteice 'sup' vs 'sec' after #) https://tc39.es/proposal-temporal/#sup-temporal.duration.prototype.tolocalestring since the details is not specified yet. Bug: v8:11544 Change-Id: I7f5a2e9766005d1a7f6409d428ca53b5a38a3960 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3696482Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#81167}
-
Etienne Pierre-doray authored
CreateJob() is similar to PostJob() but doesn't schedule anything until Join() or Notify*() is called. This allows - CreateJob().Join() without too many worker. - Early 'empty' CreateJob() for initialization without causing spurious calls to GetMaxConcurrency() Bug: chromium:1287665 Change-Id: I8fd8b139392ad30218f0cf8f580b2d76f1078777 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3668842Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81166}
-
- 14 Jun, 2022 37 commits
-
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/8f5c7aed0..b1f49b5c Bug: v8:7834 Change-Id: Icb4ab0c9b26962ed60ba30419f3976ddf05e91e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704910Reviewed-by:
-
Danylo Boiko authored
- source resolver clean up - started inregration of turboshaft schedule phase Bug: v8:7327 Change-Id: I4335c275f4cfb2e313ac383a5b9fa12c7b9aa744 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3700078Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Danylo Boiko <danielboyko02@gmail.com> Cr-Commit-Position: refs/heads/main@{#81164}
-
Darius M authored
For FixedDoubleArrays that are not aligned on 8 bytes, the SIMD fast path of array.IndexOf actually falls back on a scalar loop. Because of how this loop was written, it was failing to see that 0.0 == -0.0. Bug: chromium:1335445 Change-Id: Idf70fd3ed9950e5b2b7cc72bb2ebca6879b3a04e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702803Reviewed-by:
-
Anton Bikineev authored
This fixes an ODR violation: the macro V8_TARGET_ARCH_ARM64 was only visible when building V8, but not outside it. The CL implements a quick fix that relies on compiler-based macros (__aarch64__). The proper fix would be to make these target macros be part of the public config. Bug: chromium:1336222 Change-Id: I46ba6c1a3cd1ac4fcd3aced60ee112e6098eba6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3705540 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Camillo authored
"Function:" and "LazyCompile:" are confusing by now and use up too much space.# Enter a description of the change. This also changes the function names visible when using linux-perf Change-Id: Ib2d4b7df39068c27b5b06db578fc550d2973ebb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693705 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81161}
-
Junliang Yan authored
Change-Id: I78ef9bf817f32b8f2b96092ed9f77f223b2aa381 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702975Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#81160}
-
Camillo authored
Bug: v8:7700 Change-Id: Ib5b6b570829cfb7de9c61115b45bb37437c70dde Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702804Reviewed-by:
-
Dominik Inführ authored
Shrink life range of worklists and add IsEmpty-CHECKs for them. Also move some logic into its own method ProcessChunksWithEmptyBuckets. Bug: chromium:1336158 Change-Id: Ia2f34c824f5b1c5d61391a1a1243a46881040de1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704511 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This prevents accidental use for release branch merging, which works but shouldn't. Change-Id: I4db99bb721c935a8a1c7c44c1b4d909f44a8bf9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3705382 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: v8:7700 Change-Id: I1f552587403bdec439c611d56d6bf4c54508a76f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702802Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81156}
-
Michael Lippautz authored
In preparation for removing the finalization step, simplify incremental marking logic. Change-Id: I929034e389edb0c9da78cd39fd497d5783aff7c4 Bug: v8:12775 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704509Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81155}
-
Maya Lekova authored
Bug: chromium:1052746 Change-Id: If5c7b9871047ea27a76efa4f04c9e6c0ea48b6ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3705381 Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Andy Wingo authored
Bug: v8:12868 Change-Id: I56ccab1a0cfacfae236c4f87c31a84d3afecafc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702437 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81153}
-
Vasili Skurydzin authored
profiling is enabled Bug: v8:12952 Change-Id: I4cb41a5fa0e72522b0952c1b8264760e5235c2b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3699406Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Vasili Skurydzin <vasili.skurydzin@ibm.com> Reviewed-by:
-
Andy Wingo authored
Bug: v8:12868 Change-Id: I7f5487dc01b006caef582f792e007d3a3cabb324 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702435 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
-
Leszek Swirski authored
roll_merge_gerrit.py now loops, waiting for the merge to be submitted. Once it is, it adds a tag with the version number. Bug: v8:12849 Change-Id: I7c2765877efad2ccbe082b984642f5e989dc3c8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3705379Reviewed-by:
-
Leszek Swirski authored
This reverts commit 066d0233. Reason for revert: Failing on GPU bots, e.g. https://ci.chromium.org/ui/p/v8/builders/ci/Mac%20V8%20FYI%20Release%20(Intel)/17647/overview Original change's description: > Reland "[turbofan] Support additional operators in SLVerifier" > > This is a reland of commit dec4bb06 > > Original change's description: > > [turbofan] Support additional operators in SLVerifier > > > > This CL extends SimplifiedLoweringVerifier by a few additional operators. > > > > It fixes the missing type on a LoadElement node generated during > > js-typed-lowering, that was detected by the verifier. > > > > Bug: v8:12619 > > Change-Id: I14e3ece15f6a90e6906c140696dcd2e6b74a2527 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3557510 > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#80014} > > Bug: v8:12619 > Change-Id: If3cb6efe2005c41118f37b39b0209195b3e63a38 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702330 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81125} Bug: v8:12619 Change-Id: I0869f3abd634026a4ac852eebe186e6ccc7c3e31 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3705380 Owners-Override: Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81149}
-
Liviu Rau authored
- removed some 'feature envy' instances: - created a AugmentedOptions class to take care of non trivial option look-ups - moved some calculation closer the the actual data - promoted parameter that was passed around a lot (options) to filed in the offending class - similar object creation looks a bit more similar - CommandContext provides a wrapper that ensures resource de-allocation - separate tests from standard and num_fuzz runners - added a couple of more tests to improve coverage This is still in flux. But further changes risk creating a disconnect between the original implementation and further refactorings. Bug: v8:12785 Change-Id: I0ec2e9c6a81604a5cd1d4a80982dd3329c1b48db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3686411 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81148}
-
Leszek Swirski authored
Bug: v8:7700 Change-Id: If242def89e2ce1e7a8da3619fb514e457d83c5ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702442Reviewed-by:
-
Alexander Schulze authored
The chromium.tests pool migrates to Windows 1909 (Windows-10-18363). We switch to the same version due to higher bot availability (for now). Bug: chromium:1335886,chromium:1124829 Change-Id: I82177ad9a86b438a46747998b1fbd4108911d17b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704498 Auto-Submit: Alexander Schulze <alexschulze@chromium.org> Commit-Queue: Alexander Schulze <alexschulze@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#81146}
-
Clemens Backes authored
The CHECK was checking that we return the exception sentinel if an exception is pending. The other way is actually equally important: If we return the exception sentinel, a pending exception must be scheduled. Since the CEntry stub assumes that all values returned from runtime functions are valid tagged values (pointing into the JS heap), do also check that. This check would have prevented the linked issue. Bug: chromium:1311960 R=jkummerow@chromium.org CC=cbruni@chromium.org Change-Id: I833d2968529e3b73f3009e0104b46182197c2d23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675098Reviewed-by:
-
Andy Wingo authored
Bug: v8:12868 Change-Id: I9b7cbd3851b3819bcc2c32e273ddae16b9d812ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702266Reviewed-by:
-
Leszek Swirski authored
This reverts commit 76a07814. Reason for revert: Failing on GC stress: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20GC%20Stress/23140/overview Original change's description: > [wasm-gc] Implement array.init_from_elem > > Bug: v8:7748 > Change-Id: I65dbb496302045820063bd0f4f9ea054e6a645bd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695580 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81128} Bug: v8:7748 Change-Id: Ia72cc121c50af7906e54a1742529bf081c511a8a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704506 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81143}
-
Jakob Kummerow authored
The names we returned in WasmOpcodes::OpcodeName(...) for Atomics opcodes did not match the spec. This patch fixes that. This matters in particular when we want to provide disassembly of modules. Bug: v8:6532 Change-Id: Ia8791feee617b75d598ad373bafba7da5687f523 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704496 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Andreas Haas authored
Asynchronous WebAssembly compilation returns the compilation result through resolving a result promise. So far the result promise was resolved through V8-internal APIs. This caused problems, because resolving promises requires correct handling of microtasks, and microtasks are controlled by the embedder, and not by V8. This CL adds an API to allow the embedder to resolve the result promise itself, and handle microtasks as necessary. The use of the new API is available in a full CL, without API dance: https://chromium-review.googlesource.com/c/v8/v8/+/3694975 R=cbruni@chromium.org Bug: v8:12953 Change-Id: Ie9a56041f2d3e0c46664f1938e995f1e2c22f981 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695584Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Leszek Swirski authored
rep stos appears to be much slower for small stacks. Use pushq instead, in a loop, unrolled to push eight at a time. Bug: v8:7700 Change-Id: Ieddf52ed514cb86f5c1dd7b159cc9a1a1c440103 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702440Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81140}
-
Dominik Inführ authored
We already make code pages writable & executable for concurrent Sparkplug. We can use the same mechanism for sweeping of code pages on the background thread, instead of scheduling incremental tasks on the main thread. This allows us to remove almost all special handling for code pages in the sweeper and allows us to off-load more work from the main thread. Bug: v8:12967 Change-Id: Idb8e9f8e2eadbec26a386f2de683a80087f671f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695557Reviewed-by:
-
Igor Sheludko authored
Bug: v8:12965 Change-Id: I16b67335978714f05658f75f7a9a038270dbd69b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702337 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: v8:12968 Change-Id: I87d2ec47a250e4f69cf5c7002c254bd50276004b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702800Reviewed-by:
-
jameslahm authored
This CL adds serialization and deserialization support for ArrayBuffer and TypedArray. TODOs: - Support resizable ArrayBuffer. - Support detached ArrayBuffer. - Support shared ArrayBuffer. Bug: v8:11525 Change-Id: Ic9267a78e427ee20d55f2f0483b677eeee5c214b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688896 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
Leszek Swirski authored
Check the turbofan and maglev filters when deciding whether to tier up, rather than tiering up even when filters don't pass, then failing to compile when actually trying the compilation. Change-Id: I92eac9aaca1e33e97b77afcc531b9af4d3a9288a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702444 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Milad Fa authored
Currently getting the following errors: ``` error: variable 'string' set but not used unused variable 'start' ``` Bug: v8:12868 Change-Id: I9ee8a14da7d126270255558a630ffd2af3f87f15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702966 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
-
Tobias Tebbi authored
This reverts commit ae55e4d2. Reason for revert: blocks Chromium roll: https://ci.chromium.org/ui/p/chromium/builders/try/android-pie-arm64-rel/b8811418393278278849/overview Original change's description: > [sandbox] Enable sandboxed pointers on Android > > Bug: chromium:1218005 > Change-Id: Ie7c100193848544e661ee62f88be4601426a4e18 > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702251 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Samuel Groß <saelo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81117} Bug: chromium:1218005 Change-Id: I78c6d44c917e217bfd5ab1ab893e7b417a63a99a Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3702799 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Owners-Override: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#81133}
-
Andreas Haas authored
The native module cache makes it difficult to test deserialization, because the native module just gets loaded from the cache instead of deserializing the serialized module. This CL adds a new flag, --wasm-native-module-cache-enabled, to control whether the native module cache is enabled or not. The cache gets disabled by handling all modules like asm.js modules when the cache gets disabled, as the cache is not used for asm.js. The name of the flag is positive (i.e. `enabled` instead of `disabled`) to avoid double negation. The flag is true by default, and set to false in tests. R=thibaudm@chromium.org CC=clemensb@chromium.org Bug: v8:12964 Change-Id: If2b96a95ccf37f2eb8a868ad1661c3325c1048f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3703836 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#81132}
-
Patrick Thier authored
When using the StringForwardingTable for all strings, string shapes can change during GC. This led to an issue when a ConsString was transitioned to a ThinString (and potentially shortcutted to InternalizedString) while flattening. Bug: chromium:1335826, chromium:1329726 Change-Id: Ide243a5e24fd41374053972fb7bab8217d7a14fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3705377Reviewed-by:
-
Tobias Tebbi authored
This reverts commit dac61556. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20no-concurrent-marking/9288/overview Original change's description: > [inspector] Allow Debugger.setScriptSource to edit top-most function > > This CL adds a new boolean flag on the Debugger.setScriptSource CDP > method that gets piped all the way through to the live-edit mechanism. > The new flag enables live-editing of the top-most function while > paused. > > The CL adds a couple of tests that cover the new core use cases for > this flag. > > R=jarin@chromium.org > > Bug: chromium:1334484 > Change-Id: I12fec591b2b6550d89748714620e629548e1b9c1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695354 > Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81127} Bug: chromium:1334484 Change-Id: I165269d6c1b001b516f10ae3716ffb57b675ab39 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3705378 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Owners-Override: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#81130}
-
Leszek Swirski authored
Empty blocks were skipped when performing register merges (since they don't have a state), but we were still doing phi value injection only when visiting the empty block. This meant that empty blocks have inconsistent register state with the nodes they are trying to use. Fix this by removing the skipping code, and adding a register merge state to empty blocks. Bug: v8:7700 Change-Id: I305b1474c1f956c5c5775c62e3cd1d0c70b5cfdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3698553Reviewed-by:
-
