- 23 Jul, 2018 15 commits
-
-
Théotime Grohens authored
This CL makes the unoptimized DataView getter and setter methods output the right function name when throwing an exception, instead of a generic one. It also contains a little drive-by cleanup of the Torque code to keep it up to date with the language. Change-Id: I10eb37090a0206172e470b5958af6a5968f3836f Reviewed-on: https://chromium-review.googlesource.com/1146570 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54615}
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: Ic39751e4509bc4d3280e1ae03162af5a97de7deb Reviewed-on: https://chromium-review.googlesource.com/1146807Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54614}
-
Ross McIlroy authored
Use the new Isolate version of the methods. BUG=v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id4f10d23927d6ae50cb458b5cac744617fa83e53 Reviewed-on: https://chromium-review.googlesource.com/1145387Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#54613}
-
Maya Lekova authored
Bug: chromium:866315 Change-Id: I83074475185c0646d575282d24679e18ec0628c7 Reviewed-on: https://chromium-review.googlesource.com/1146645 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54612}
-
Sigurd Schneider authored
This reverts commit 2c4c2ad6. Reason for revert: Speculatively revert CL, as it seems to break blink debug bots: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064%20(dbg)/12756 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064%20(dbg)/12764 # Fatal error in ../../v8/src/api.cc, line 5960 # Check failed: expected == value ((nil) vs. 0x176ae0f70a48). Original change's description: > Avoiding re-externalization of strings. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I75bddcf0e8879d2161486f24d1cd4e46d8fe008d > Reviewed-on: https://chromium-review.googlesource.com/1139056 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54599} TBR=ulan@chromium.org,jkummerow@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:845409 Change-Id: Ie172148c0bdef71c0cf9819e63a66aec09d6888d Reviewed-on: https://chromium-review.googlesource.com/1146582 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54611}
-
Maya Lekova authored
If an exception is thrown in instrumented async code, for instance await import('non-existing-module') it should be correctly reported by the hooks that run around this code. Also calling ToLocalChecked() on the hook result is wrong if the hook has thrown an exception. Bug: chromium:865892 Change-Id: I5712376fe4426a3e49223d821e4647150887a258 Reviewed-on: https://chromium-review.googlesource.com/1146561 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54610}
-
Sigurd Schneider authored
This is a reland of 9eca23e9 Adds a deopt continuation, which fixes JavaScript stack traces to contain the number constructor after inlining. Original change's description: > [turbofan] Inline Number constructor in certain cases > > This CL adds inlining for the Number constructor if new.target is not > present. The lowering is BigInt compatible, i.e. it converts BigInts to > numbers. > > Bug: v8:7904 > Change-Id: If03b9f872d82e50b6ded7709069181c33dc44e82 > Reviewed-on: https://chromium-review.googlesource.com/1118557 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54454} Bug: v8:7904 Change-Id: Ic416e5ba81fa3a0f59ae4afa80df83c46a759487 Reviewed-on: https://chromium-review.googlesource.com/1146581 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Dan Elphick authored
Use the Isolate* version of Concat. Bug: v8:7754 Change-Id: I3d16405032ab0690c57e2ba615cac60d8fa92464 Reviewed-on: https://chromium-review.googlesource.com/1146578Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54608}
-
Ross Mcilroy authored
Replace with isolate versions BUG=v8:7754 Change-Id: I69cf1e0d4cba6d68a3983c0dba346bfc1bfc9619 Reviewed-on: https://chromium-review.googlesource.com/1146182 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
jgruber authored
Bug: v8:7754 Change-Id: Ie58571682f4dff76108180e8a707159997f7abfa Reviewed-on: https://chromium-review.googlesource.com/1145277Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54606}
-
jgruber authored
Code::contains should return true in two cases: either the given address is within the off-heap instruction stream, or within the trampoline's instruction stream. This CL fixes the second case. One effect is that code printed through the jco gdb macro again displays the builtin name correctly when given a trampoline pc. Drive-by: a more efficient Builtins::Lookup for embedded builtins. Bug: v8:6666,v8:7969 Change-Id: I54f5e5881fa2aed2546b9e62aa4b9390ad21b895 Reviewed-on: https://chromium-review.googlesource.com/1146566Reviewed-by:
-
Ross Mcilroy authored
Replace with isolate version. BUG=v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iac7091b983960d22b892074c5fd0a97dee9025c9 Reviewed-on: https://chromium-review.googlesource.com/1146332 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Simon Zünd authored
For JSProxies we filled a FixedArray with the numbers from 0 to length - 1. Because all indices were assumed to be Smis, large array indices on Proxies were not handled correctly. R=jgruber@chromium.org Bug: chromium:866314 Change-Id: I6a792e800f31617a6092b219ec82b0e05a83bf7b Reviewed-on: https://chromium-review.googlesource.com/1146562Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#54603}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6f5ee86..181a988 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ddcfa34..9e8a0b2 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I396cf06b2c5a27acb9136da5c17bce3df616b860 Reviewed-on: https://chromium-review.googlesource.com/1146157Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54602}
-
Simon Zünd authored
Drive-by change: Add std::iterator_traits typedefs to ZoneChunkListIterator so we can use <algorithm>. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: Ib7d1c622fdb761fc99bea373dbdef206f15bd4a0 Reviewed-on: https://chromium-review.googlesource.com/1145075 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54601}
-
- 21 Jul, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/385916c..6f5ee86 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d26f5c3..ddcfa34 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3899f1b..7e3c67f Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/6215064..9a5d7ce TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib443be36b0f43efd5049d33d8297f16044091eaa Reviewed-on: https://chromium-review.googlesource.com/1146022 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 20 Jul, 2018 24 commits
-
-
Rodrigo Bruno authored
Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I75bddcf0e8879d2161486f24d1cd4e46d8fe008d Reviewed-on: https://chromium-review.googlesource.com/1139056 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54599}
-
jgruber authored
This should improve the debugging experience since backtraces will list the exact builtin instead of just 'embedded_blob'. An example gdb backtrace: #0 <snip address> in Builtins_RegExpPrototypeExec () #1 <snip address> in Builtins_ArgumentsAdaptorTrampoline () <snip further frames> Bug: v8:6666, v8:7722 Change-Id: Iafc995779903e7d7a980d66e7dad42938ac7d29e Reviewed-on: https://chromium-review.googlesource.com/1145183Reviewed-by:
-
Sigurd Schneider authored
This reverts commit a462a785. Reason for revert: Breaks a TurboAssembler test: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm/7726 Original change's description: > [turboassembler] Introduce hard-abort mode > > For checks and assertions (mostly for debug code, like stack alignment > or zero extension), we had two modes: Emit a call to the {Abort} > runtime function (the default), and emit a debug break (used for > testing, enabled via --trap-on-abort). > In wasm, where we cannot just call a runtime function because code must > be isolate independent, we always used the trap-on-abort behaviour. > This causes problems for our fuzzers, which do not catch SIGTRAP, and > hence do not detect debug code failures. > > This CL introduces a third mode ("hard abort"), which calls a C > function via {ExternalReference}. The C function still outputs the > abort reason, but does not print the stack trace. It then aborts via > "OS::Abort", just like the runtime function. > This will allow fuzzers to detect the crash and even find a nice error > message. > > Even though this looks like a lot of code churn, it is actually not. > Most added lines are new tests, and other changes are minimal. > > R=mstarzinger@chromium.org > > Bug: chromium:863799 > Change-Id: I77c58ff72db552d49014614436259ccfb49ba87b > Reviewed-on: https://chromium-review.googlesource.com/1142163 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54592} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I60c011cfe262ccebbb9abf32699a9fe17e72a3c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:863799 Reviewed-on: https://chromium-review.googlesource.com/1145431 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 29379945. Reason for revert: Needed for other revert: https://chromium-review.googlesource.com/c/v8/v8/+/1145431 Original change's description: > [cleanup] Rename {kLastErrorMessage} to {kNumberOfReasons} > > The name {kLastErrorMessage} is misleading, as it's not actually the > index of the last message (or reason), but one more (i.e. number of > messages / reasons). Thus this renaming. > > R=mstarzinger@chromium.org > > Bug: v8:7754 > Change-Id: Id21edcecac84c0e6068423c6124ef2881116dc7c > Reviewed-on: https://chromium-review.googlesource.com/1145305 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54593} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I2af83f4a2299e05ad9bcacfe69c0b483fd1488de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7754 Reviewed-on: https://chromium-review.googlesource.com/1145520Reviewed-by:
-
Caitlin Potter authored
As discussed in https://docs.google.com/document/d/1sBdGe8RHgeYP850cKSSgGABTyfMdvaEWLy-vertuTCo/edit?ts=5b3ba5cc#, this CL introduces a new bytecode (CloneObject), and a new IC type. In this prototype implementation, the type feedback looks like the following: Uninitialized case: { uninitialized_sentinel, uninitialized_sentinel } Monomorphic case: { weak 'source' map, strong 'result' map } Polymorphic case: { WeakFixedArray with { weak 'source' map, strong 'result' map }, cleared value } Megamorphic case: { megamorphic_sentinel, cleared_Value } In the fast case, Object cloning is done by allocating an object with the saved result map, and a shallow clone of the fast properties from the source object, as well as cloned fast elements from the source object. If at any point the fast case can't be taken, the IC transitions to the slow case and remains there. This prototype CL does not include any TurboFan optimization, and the CloneObject operation is merely reduced to a stub call. It may still be possible to get some further improvements by somehow incorporating compile-time boilerplate elements into the cloned object, or simplifying how the boilerplate elements are inserted into the object. In terms of performance, we improve the ObjectSpread score in JSTests/ObjectLiteralSpread/ by about 8x, with substantial improvements over the Babel and ObjectAssign scores. R=gsathya@chromium.org, mvstanton@chromium.org, rmcilroy@chromium.org, neis@chromium.org, bmeurer@chromium.org BUG=v8:7611 Change-Id: I79e1796eb77016fb4feba0e1d3bb9abb348c183e Reviewed-on: https://chromium-review.googlesource.com/1127472 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=petermarshall@chromium.org Bug: v8:7754 Change-Id: I045daa428a7830fa110c74d6636921be36ca1dbe Reviewed-on: https://chromium-review.googlesource.com/1145278Reviewed-by:
-
Clemens Hammacher authored
The name {kLastErrorMessage} is misleading, as it's not actually the index of the last message (or reason), but one more (i.e. number of messages / reasons). Thus this renaming. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: Id21edcecac84c0e6068423c6124ef2881116dc7c Reviewed-on: https://chromium-review.googlesource.com/1145305 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
For checks and assertions (mostly for debug code, like stack alignment or zero extension), we had two modes: Emit a call to the {Abort} runtime function (the default), and emit a debug break (used for testing, enabled via --trap-on-abort). In wasm, where we cannot just call a runtime function because code must be isolate independent, we always used the trap-on-abort behaviour. This causes problems for our fuzzers, which do not catch SIGTRAP, and hence do not detect debug code failures. This CL introduces a third mode ("hard abort"), which calls a C function via {ExternalReference}. The C function still outputs the abort reason, but does not print the stack trace. It then aborts via "OS::Abort", just like the runtime function. This will allow fuzzers to detect the crash and even find a nice error message. Even though this looks like a lot of code churn, it is actually not. Most added lines are new tests, and other changes are minimal. R=mstarzinger@chromium.org Bug: chromium:863799 Change-Id: I77c58ff72db552d49014614436259ccfb49ba87b Reviewed-on: https://chromium-review.googlesource.com/1142163 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:7754 Change-Id: Ia4c2fb2d87c8a5de96fa9f1f0621d21ae3eda611 Reviewed-on: https://chromium-review.googlesource.com/1145181Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54591}
-
Clemens Hammacher authored
The most important point of IWYU (include-what-you-use) is that each header includes everything it is using, so that whoever includes that header does not need to additionally include other things. This CL adds a script which generates files to automatically check this. It is automatically invoked during "gclient runhooks" if the "check_v8_header_includes" variable is set. This script generates a number of .cc files in the "check-header-includes" directory, together with a "sources.gni" file which lists all the generated cc files. Each file includes one header. If additionally the gn args "v8_check_header_includes" is set, this gni file is included, and all the generated CC files will be compiled. This will detect violations of the aforementioned IWYU rule. R=titzer@chromium.org, machenbach@chromium.org Bug: v8:7754, v8:7965 Change-Id: Id1cf256507052c3a9ea82f8c80ea1c0385457e31 Reviewed-on: https://chromium-review.googlesource.com/1145199 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54590}
-
Marja Hölttä authored
string-builder.h was using functions defined in *-inl.h and that's not allowed. BUG=v8:7754,v8:7490 Change-Id: I442ff761f3a5799b60c0d02f7130bf694dca9b1b Reviewed-on: https://chromium-review.googlesource.com/1145185Reviewed-by:
-
Simon Zünd authored
R=petermarshall@chromium.org Bug: v8:7754 Change-Id: I5dde8026c80f279606c4c35c546dd41a2872aa3b Reviewed-on: https://chromium-review.googlesource.com/1145189Reviewed-by:
-
Georg Neis authored
Change-Id: Iadfec0133d45f6539fd0b2b5fbea0e39ab7dfc29 Reviewed-on: https://chromium-review.googlesource.com/1145180Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54587}
-
Simon Zünd authored
R=petermarshall@chromium.org Bug: v8:7754 Change-Id: I70e433cda81629496aef0b5b2c8b379787765c31 Reviewed-on: https://chromium-review.googlesource.com/1144932 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Michael Achenbach authored
TBR=yangguo@chromium.org NOTRY=true Bug: v8:7963 Change-Id: I1a91047b2a3c7d128f3b01a0970ce53a63c196d6 Reviewed-on: https://chromium-review.googlesource.com/1145187Reviewed-by:
-
Michael Starzinger authored
R=petermarshall@chromium.org BUG=v8:7754 Change-Id: I44d5c808195b676c05f7d4837ad18cd33c377840 Reviewed-on: https://chromium-review.googlesource.com/1145067Reviewed-by:
-
Marja Hölttä authored
This reduces the build steps from touching api.h: 269 -> 156 BUG=v8:7754,v8:7490 Change-Id: I75abaeea4cc78027a47304ff9b9f6b12bdb2b75e Reviewed-on: https://chromium-review.googlesource.com/1144929Reviewed-by:
-
Michael Starzinger authored
R=titzer@chromium.org BUG=v8:7754 Change-Id: Icf17677a3ca3c9be153b68a9a6f939259e7b7b5f Reviewed-on: https://chromium-review.googlesource.com/1143263 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7754 Change-Id: Iffd3a2f665258032e2284e5cd700f9a3286618d1 Reviewed-on: https://chromium-review.googlesource.com/1145064Reviewed-by:
-
Simon Zünd authored
R=jgruber@chromium.org Bug: v8:7754 Change-Id: Iec5f0a3f4f948a5f55c112324f4db68c69df2dbd Reviewed-on: https://chromium-review.googlesource.com/1145061Reviewed-by:
-
Leszek Swirski authored
Adds an Isolate::FromWritableHeapObject method, with a bool return value and Isolate* out parameter, and replace most accesses to Isolate via MemoryChunk (which handle objectsin ROSpace rather than just failing) to use that instead. Bug: v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idb472a3d6037deed92e6fa8c8a7a1a14293e2462 Reviewed-on: https://chromium-review.googlesource.com/1144933 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54579}
-
Marja Hölttä authored
BUG=v8:7754,v8:5402 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I5306005e7d0fcfe188c9e0270a003c6e1098c9e9 Reviewed-on: https://chromium-review.googlesource.com/1144824Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/20c1311..3899f1b Rolling v8/tools/luci-go: https://chromium.googlesource.com/chromium/src/tools/luci-go/+log/abcd908..445d7c4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ibd109913b42c2bd758855378ac61fb1a6a4f5cfe Reviewed-on: https://chromium-review.googlesource.com/1145040Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:838864 Change-Id: I8242537847615848a3c2e6bdf39509c4692882ae Reviewed-on: https://chromium-review.googlesource.com/1143474 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
