1. 10 Aug, 2016 1 commit
  2. 18 Mar, 2016 1 commit
  3. 12 Dec, 2015 1 commit
  4. 06 Nov, 2015 1 commit
  5. 30 Sep, 2015 1 commit
  6. 26 Aug, 2015 1 commit
  7. 25 Aug, 2015 2 commits
  8. 21 Aug, 2015 1 commit
    • rossberg's avatar
      [es6] Parameter scopes for sloppy eval · 365fd7bc
      rossberg authored
      This CL is a nightmare! For the utterly irrelevant edge case of a sloppy function with non-simple parameters and a call to direct eval, like here,
      
        let x = 1;
        function f(g = () => x) {
          var y
          eval("var x = 2")
          return g() + x  // f() = 3
        }
      
      we have to do all of the following, on top of the declaration block ("varblock") contexts we already introduce around the body:
      
      - Introduce the ability for varblock contexts to have both a ScopeInfo and an extension object (e.g., the body varblock in the example will contain both a static var y and a dynamic var x). No other scope needs that. Since there are no context slots left, a special new struct is introduced that pairs up scope info and extension object.
      
      - When declaring lookup slots in the runtime, this new struct is allocated in the case where an extension object has to be added to a block scope (at which point the block's extension slot still contains a plain ScopeInfo).
      
      - While at it, introduce some abstraction to access context extension slots in a more controlled manner, in order to keep special-casing to a minimum.
      
      - Make sure that even empty varblock contexts do not get optimised away when they contain a sloppy eval, so that they can host the potential extension object.
      
      - Extend dynamic search for declaration contexts (used by sloppy direct eval) to recognize varblock contexts.
      
      - In the parser, if a function has a sloppy direct eval, introduce an additional varblock scope around each non-simple (desugared) parameter, as required by the spec to contain possible dynamic var bindings.
      
      - In the pattern rewriter, add the ability to hoist the named variables the pattern declares to an outer scope. That is required because the actual destructuring has to be evaluated inside the protecting varblock scope, but the bindings that the desugaring introduces are in the outer scope.
      
      - ScopeInfos need to save the information whether a block is a varblock, to make sloppy eval calls work correctly that deserialise them as part of the scope chain.
      
      - Add the ability to materialize block scopes with extension objects in the debugger. Likewise, enable setting extension variables in block scopes via the debugger interface.
      
      - While at it, refactor and unify some respective code in the debugger.
      
      Sorry, this CL is large. I could try to split it up, but everything is rather entangled.
      
      @mstarzinger: Please review the changes to contexts.
      @yangguo: Please have a look at the debugger stuff.
      
      R=littledan@chromium.org, mstarzinger@chromium.org, yangguo@chromium.org
      BUG=v8:811,v8:2160
      LOG=N
      
      Review URL: https://codereview.chromium.org/1292753007
      
      Cr-Commit-Position: refs/heads/master@{#30295}
      365fd7bc
  9. 17 Aug, 2015 1 commit
  10. 01 Jun, 2015 2 commits
    • caitpotter88's avatar
      Revert of [es6] implement default parameters via desugaring (patchset #19... · 904fbc30
      caitpotter88 authored
      Revert of [es6] implement default parameters via desugaring (patchset #19 id:380001 of https://codereview.chromium.org/1127063003/)
      
      Reason for revert:
      Broken on arm64
      
      Original issue's description:
      > [es6] implement default parameters via desugaring
      >
      > Stage 1 implementation:
      >
      > - Parameters can't be referenced before initialized (from left-to-right)
      > - SingleNameBindings only, no support for BindingPatterns
      >
      > Known issues:
      >
      > - Incorrect scoping (parameter expressions may reference variables declared in function body)
      > - Function arity is untouched
      > - Hole-checking needs work
      > - Rest parameters are broken when mixed with optional arguments
      >
      > BUG=v8:2160
      > LOG=N
      > R=arv@chromium.org, rossberg@chromium.org
      >
      > Committed: https://crrev.com/892c85485881f8be2f17bd83238980f858126576
      > Cr-Commit-Position: refs/heads/master@{#28739}
      
      TBR=rossberg@chromium.org,wingo@igalia.com,arv@chromium.org,dslomov@chromium.org,adamk@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:2160
      
      Review URL: https://codereview.chromium.org/1163853002
      
      Cr-Commit-Position: refs/heads/master@{#28740}
      904fbc30
    • caitpotter88's avatar
      [es6] implement default parameters via desugaring · 892c8548
      caitpotter88 authored
      Stage 1 implementation:
      
      - Parameters can't be referenced before initialized (from left-to-right)
      - SingleNameBindings only, no support for BindingPatterns
      
      Known issues:
      
      - Incorrect scoping (parameter expressions may reference variables declared in function body)
      - Function arity is untouched
      - Hole-checking needs work
      - Rest parameters are broken when mixed with optional arguments
      
      BUG=v8:2160
      LOG=N
      R=arv@chromium.org, rossberg@chromium.org
      
      Review URL: https://codereview.chromium.org/1127063003
      
      Cr-Commit-Position: refs/heads/master@{#28739}
      892c8548